Remove unused errors #3637
Merged
Remove unused errors #3637
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
RyanCavanaugh
commented
Jun 25, 2015
RyanCavanaugh
commented
- Removes errors that aren't used by the compiler (mostly duplicates)
- Adds a script that finds these + finds errors that aren't anywhere in the baselines (in case we get bored some day and need something to do...)
| let glob = require('glob'); | ||
|
|
||
| fs.readFile('src/compiler/diagnosticMessages.json', 'utf-8', (err, data) => { | ||
| let messages = JSON.parse(data); |
There was a problem hiding this comment.
This file uses tabs, switch to spaces
| count++; | ||
| } | ||
| } | ||
| console.log(count + ' of ' + keys.length + ' errors are not in baselines'); |
There was a problem hiding this comment.
What are the numbers your found?
There was a problem hiding this comment.
138 of 535 errors are not in baselines
There was a problem hiding this comment.
Note that a decent number of those are e.g. commandline option descriptions, which aren't actually errors
|
👍 |
1 similar comment
|
👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.