Support extensionless <reference> comments. #365
Conversation
|
@danquirk @RyanCavanaugh The new test in this commit is intended to check that the compiler correctly resolves extensionless comments. However, I suspect the test harness passes all of the file names to the compiler, so resolution is only partially checked. What's the best way to do this? |
| errors.push(createFileDiagnostic(refFile, start, length, Diagnostics.File_0_not_found, filename)); | ||
| else { | ||
| if (!(findSourceFile(filename + ".ts", isDefaultLib, refFile, refPos, refEnd) || findSourceFile(filename + ".d.ts", isDefaultLib, refFile, refPos, refEnd))) { | ||
| errors.push(createFileDiagnostic(refFile, start, length, Diagnostics.File_0_not_found, filename + ".ts")); |
There was a problem hiding this comment.
Error message is a bit misleading since it says only about failed attempt to find .ts file.
There was a problem hiding this comment.
Agreed, but honestly not worth it to add another error message.
|
👍 |
1 similar comment
|
👍 |
Support extensionless <reference> comments.
|
@ahejlsberg you'll probably want to add a project test for this since that more closely matches the end to end compiler pipeline with resolution and emit. You add a specification for the test in tests/cases/project and then accompanying sources in tests/cases/projects. |
Fixes #344.