Fix attribute completion following JSX exprs #3699
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
| jsxNode = jsxNode.parent; | ||
| if (attrsType) { | ||
| symbols = typeChecker.getPropertiesOfType(attrsType); |
There was a problem hiding this comment.
you probably should filter these based on the ones already defined. you do not want to keep suggesting the same property over and over. i am assuming it is expected to define the same property multiple time outside a spread.
There was a problem hiding this comment.
e.g. filterObjectMembersList and filterModuleExports
There was a problem hiding this comment.
✔️ added a verification to the test as well
|
👍 |
RyanCavanaugh
added a commit
that referenced
this pull request
Jul 2, 2015
Fix attribute completion following JSX exprs
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes bug #3695