Skip to content

Conversation

a-tarasyuk
Copy link
Contributor

Fixes #37364

@sandersn sandersn added the For Milestone Bug PRs that fix a bug with a specific milestone label Mar 25, 2020
@elibarzilay
Copy link
Contributor

(I made a minor change, leaving the original expression function instead of the return thing.)

@a-tarasyuk
Copy link
Contributor Author

@elibarzilay Thanks for your changes 👍, you are right the return statement was useless., I'm not sure that new changes for ternary operator have the right indentation., it seems that condition has been formatted without addition indentation. Some time ago I was working on migration the repo to the eslint and as I remember correctly, the following formatting was not acceptable for eslint/indent before we disabled it due to performance reasons. Can @uniqueiniquity you check?, maybe I'm wrong.

expression
? true
: false

Is it acceptable to do like so?

 symbols: type.getApparentProperties().filter(prop =>
     !isPrivateIdentifierPropertyDeclaration(isTransientSymbol(prop) && prop.syntheticOrigin ? prop.syntheticOrigin.valueDeclaration : prop.valueDeclaration)),

or

symbols: type.getApparentProperties().filter(prop =>
    !isPrivateIdentifierPropertyDeclaration(
        isTransientSymbol(prop) && prop.syntheticOrigin ? prop.syntheticOrigin.valueDeclaration : prop.valueDeclaration)),

cc @andrewbranch

@elibarzilay
Copy link
Contributor

(@a-tarasyuk, it's used elsewhere too, but in any case I just wanted to shorten the line...)

@elibarzilay elibarzilay merged commit aa6be6e into microsoft:master Apr 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
For Milestone Bug PRs that fix a bug with a specific milestone
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

No completions in string literal index on mapped type
4 participants