Fix #3764 #3770
Merged
Fix #3764 #3770
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // If we're compiling under --jsx react, the symbol 'React' should | ||
| // be marked as 'used' so we don't incorrectly elide its import. And if there | ||
| // is no 'React' symbol in scope, we should issue an error. | ||
| if(compilerOptions.jsx === JsxEmit.React) { |
|
👍 after feedback is addressed |
|
👍 |
|
Wasn't this the second "marking something as used" bug having to do with JSX? This "marking something as used" thing is... pretty annoying. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We weren't marking
Reactas used when using JSX elements in--jsx React, which caused the import of that symbol to be elided.Fix: Mark this symbol as used and issue an error if it can't be found.
Ref #3764