Skip to content

Allow distinct string enum members with identical property names to form unions in mapped types #39101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 29, 2020
Merged

Allow distinct string enum members with identical property names to form unions in mapped types #39101

merged 1 commit into from
Jun 29, 2020

Conversation

andrewbranch
Copy link
Member

Fixes #37859

See bug for discussion.

@andrewbranch andrewbranch requested a review from weswigham June 16, 2020 23:50
@andrewbranch andrewbranch requested a review from ahejlsberg June 26, 2020 21:48
@andrewbranch
Copy link
Member Author

Thanks for the review!

@andrewbranch andrewbranch merged commit 58ed610 into microsoft:master Jun 29, 2020
@andrewbranch andrewbranch deleted the bug/37859 branch June 29, 2020 17:08
@ahejlsberg ahejlsberg mentioned this pull request Jul 16, 2020
Closed
@ahejlsberg ahejlsberg mentioned this pull request Dec 22, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahejlsberg ahejlsberg ahejlsberg approved these changes

@weswigham weswigham Awaiting requested review from weswigham

Assignees

@andrewbranch andrewbranch

Labels
Author: Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Map derived from discriminated union has wrong type when discriminator property has the same value
3 participants
@andrewbranch @ahejlsberg @typescript-bot