Skip to content

Conversation

Jack-Works
Copy link
Contributor

@Jack-Works Jack-Works commented Jun 24, 2020

@Kingwl
Copy link
Contributor

Kingwl commented Jun 24, 2020

You need pass all test and then we can pack this.

@Jack-Works
Copy link
Contributor Author

You need pass all test and then we can pack this.

Sorry! I have temporally disabled these tests to make it pass. (Since it's an early prototype). Can you pack it now? The build passed. Thanks! @Kingwl

@Kingwl
Copy link
Contributor

Kingwl commented Jun 24, 2020

Let's try it!
@typescript-bot pack this.

@typescript-bot
Copy link
Collaborator

typescript-bot commented Jun 24, 2020

Heya @Kingwl, I've started to run the tarball bundle task on this PR at f4df92d. You can monitor the build here.

@typescript-bot
Copy link
Collaborator

typescript-bot commented Jun 24, 2020

Hey @Kingwl, I've packed this into an installable tgz. You can install it for testing by referencing it in your package.json like so:

{
    "devDependencies": {
        "typescript": "https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_apis/build/builds/77664/artifacts?artifactName=tgz&fileId=B75A191F9450B379F5D65629FA5E34FB66EF5D5A76B581EFAAFF8A824994F7A402&fileName=/typescript-4.0.0-insiders.20200624.tgz"
    }
}

and then running npm install.


There is also a playground for this build.

@Jack-Works
Copy link
Contributor Author

reach stage 1! 🎉

@typescript-bot typescript-bot added the For Uncommitted Bug PR for untriaged, rejected, closed or missing bug label Jul 26, 2020
if (token() !== SyntaxKind.DotToken) return undefined;
nextToken(); // advance past the dot
if (!tokenIsIdentifierOrKeyword(token())) return undefined;
const id = parseIdentifierName().escapedText;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to current spec, we should emit error when the identifier contains escape.

await . r\u{61}ce

is not an await operation expression.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's an early prototype and I'm not familiar with TS tokenizer/scanner so won't fix in the current stage

@Jack-Works
Copy link
Contributor Author

withdraw the proposal

@Jack-Works Jack-Works closed this Mar 10, 2022
@Jack-Works Jack-Works deleted the await.ops branch March 10, 2022 11:19
@Jack-Works Jack-Works restored the await.ops branch March 10, 2022 23:40
@Jack-Works Jack-Works reopened this Mar 10, 2022
@Jack-Works
Copy link
Contributor Author

withdraw rejected 🤔

@Jack-Works
Copy link
Contributor Author

close for now. I'll re-open and rebase this once the proposal gets advanced.

@Jack-Works Jack-Works closed this Aug 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
For Uncommitted Bug PR for untriaged, rejected, closed or missing bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants