Report error if the entityname reference in the import declaration is us... #413
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… using private module
…fier meaning is also value
…nnot be named Adds test cases too
| function writeAsychronousImportDeclarations(importDeclarations: ImportDeclaration[]) { | ||
| var oldWriter = writer; | ||
| forEach(importDeclarations.sort(), aliasToWrite => { | ||
| var aliasEmitInfo = forEach(aliasDeclarationEmitInfo, declEmitInfo => declEmitInfo.declaration === aliasToWrite ? declEmitInfo : undefined); |
There was a problem hiding this comment.
why do we need to sort the declarations?
There was a problem hiding this comment.
we need to sort that because the text is patched correctly and we don't need to track partial edits. The asynchronous output could make declaration in reverse or random order to be in importDeclarations list
There was a problem hiding this comment.
I am not sure I understand, an example may be helpful :)
There was a problem hiding this comment.
hm.. sorry I thought you were talking about the code that was patching asynchronous code. The sort is not needed here. I am updating it.
Make changes to report error if the type used from external module cannot be named
Emit Type of function and static function correctly in declaration file
sheetalkamat
added a commit
that referenced
this pull request
Aug 14, 2014
Report error if the entityname reference in the import declaration is us...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Report error if the entityname reference in the import declaration is using private module