Skip to content

RegExp function return types #415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 11, 2014
Merged

RegExp function return types #415

merged 2 commits into from
Aug 11, 2014

Conversation

ivogabe
Copy link
Contributor

@ivogabe ivogabe commented Aug 9, 2014

Return value of String.match should have an optional index and input property, so I created an interface that adds these properties and extends string[]. Also RegExpExecArray should extend string[] instead of copying all the members of Array. Fixes #184

@mhegazy
Copy link
Contributor

mhegazy commented Aug 9, 2014

👍

mhegazy added a commit that referenced this pull request Aug 11, 2014
@mhegazy
Merge pull request #415 from ivogabe/regexp
851e335 
RegExp function return types
@mhegazy mhegazy merged commit 851e335 into microsoft:master Aug 11, 2014
@ivogabe ivogabe deleted the regexp branch August 11, 2014 18:29
@microsoft microsoft locked and limited conversation to collaborators Jun 18, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Return value of String.match has an index property
2 participants
@ivogabe @mhegazy