-
Notifications
You must be signed in to change notification settings - Fork 13k
Add codefix and completions for promoting existing type-only imports to non-type-only #47552
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@typescript-bot pack this |
Heya @andrewbranch, I've started to run the tarball bundle task on this PR at 280ad8e. You can monitor the build here. |
@typescript-bot pack this |
Heya @andrewbranch, I've started to run the tarball bundle task on this PR at 8dee845. You can monitor the build here. |
Hey @andrewbranch, I've packed this into an installable tgz. You can install it for testing by referencing it in your
and then running There is also a playground for this build and an npm module you can use via |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just some minor questions.
I had a chance to test this out for #47631 and it's 😻😻😻😻😻😻 for our project! Thanks so much, @andrewbranch and @typescript-bot! |
Fixes #44804
We may want a corresponding VS Code update, because there is currently no indication in the completion details display that this completion has an associated action, even though we send a localized description with the code actions. I only just noticed that VS Code never uses that description; instead, the “Auto-import from ...” text seems to be hard-coded in the extension.
Was trying to get a screen recording, but my recorder software is crashing.