Delete generated file, add to gitignore #4915
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
weswigham
added a commit
that referenced
this pull request
Sep 22, 2015
Delete generated file, add to gitignore
|
I think the original reason that we did this was because of some intermingling between sys and diagnostics. I think this should be fine now. |
|
This serves a very sub-par editing experience if I haven't performed a |
|
Yes. We mentioned that in #4909 when discussing if this was desirable. It's pretty much the only downside, but reduces merge issues. |
|
I recommend a post-checkout hook to build the file, if you like having a reliable editing experience. |
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #4909
Our build was already setup to handle building the process messages script and processing the messages before building the compiler.
jakewith none of the generated files present will create them all correctly.Removing the generated code form the repo should reduce merge conflicts in PRs and hopefully now provide a build failure warning when IDs clash in the json file.