Improve JSX invalid children type error #52105
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
typescript-bot
added
Author: Team
For Milestone Bug
gabritto
commented
Jan 4, 2023
| * Assumes `target` type is assignable to the `Iterable` type, if `Iterable` is defined, | ||
| * or that it's an array-like type, if `Iterable` is not defined. | ||
| */ | ||
| function elaborateIterableOrArrayLikeTargetElementwise( |
There was a problem hiding this comment.
This function was copied from the existing elaborateElementwise function, and then modified to work with a target that is iterable or array-like. Some parts of the elaboration were removed because I figured they didn't apply in this specific case, and some were adapted.
weswigham
approved these changes
Jan 5, 2023
|
@typescript-bot perf test this faster |
|
Heya @gabritto, I've started to run the diff-based user code test suite on this PR at ee4ea51. You can monitor the build here. Update: The results are in! |
|
Heya @gabritto, I've started to run the diff-based top-repos suite on this PR at ee4ea51. You can monitor the build here. Update: The results are in! |
|
Heya @gabritto, I've started to run the abridged perf test suite on this PR at ee4ea51. You can monitor the build here. Update: The results are in! |
|
@gabritto Here are the results of running the user test suite comparing Everything looks good! |
|
@gabritto Here are the results of running the top-repos suite comparing Everything looks good! |
|
@gabritto Here they are:Comparison Report - main..52105
System
Hosts
Scenarios
Developer Information: |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #48796.
The original error elaboration tried to detect whether a component expected multiple children or just one by checking if the types were array-like. However, the type definition of
ReactNode, more specifically of itsReactFragmentcomponent, were updated to useIterable<ReactNode>. So that meant that, if a component expected children of typeReactNode(orReactFragment, we'd think it was expecting a single child, becauseIterable<ReactNode>is not an array-like type, so the error message reflected that, leading to TS confusingly saying the component expected a single child even when an array of children of the correct type would be accepted.I updated that error elaboration to use assignability to
Iterable(when this type is defined) as the way to differentiate between components expecting a single child or multiple children. I also had to further change the error elaboration used to account for an use ofIterable.