Skip to content

fix(52270): update optionalReplacementSpan in continuePreviousIncompleteResponse #52287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 20, 2023
Merged

fix(52270): update optionalReplacementSpan in continuePreviousIncompleteResponse #52287

merged 2 commits into from
Jan 20, 2023

Conversation

jadestrong
Copy link
Contributor

Fixes #52270

@typescript-bot typescript-bot added the For Uncommitted Bug PR for untriaged, rejected, closed or missing bug label Jan 18, 2023
@DanielRosenwasser
Copy link
Member

We'll need a regression test - something that wasn't working before this change, but does work now.

@andrewbranch
Copy link
Member

I don’t think there’s a way to write a test for this besides asserting the optionalReplacementSpan you expect in a unit test in src/testRunner/unittests/tsserver/completionsIncomplete.ts. The fourslash tests aren’t set up to do continuations IIRC.

@jadestrong
Copy link
Contributor Author

image

I tried to add a regression test, here are the test results before this change

@jadestrong
Copy link
Contributor Author

@microsoft-github-policy-service agree

andrewbranch
andrewbranch approved these changes Jan 20, 2023
View reviewed changes
Copy link
Member

@andrewbranch andrewbranch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this and fixing it! 🌟

@andrewbranch andrewbranch merged commit 1e99934 into microsoft:main Jan 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewbranch andrewbranch andrewbranch approved these changes

Assignees

@andrewbranch andrewbranch

Labels
For Uncommitted Bug PR for untriaged, rejected, closed or missing bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

optionalReplacementSpan not update when hit a incompleteCompletionsCache?
4 participants
@jadestrong @DanielRosenwasser @andrewbranch @typescript-bot