Fix crash in union subtype reduction involving template literal and string mapping types

[ahejlsberg]

Fixes #52685.

[jakebailey]

@typescript-bot test this
@typescript-bot test top100
@typescript-bot user test this
@typescript-bot perf test this

[typescript-bot]

Heya @jakebailey, I've started to run the diff-based top-repos suite on this PR at 294a3a9. You can monitor the build here.

Update: The results are in!

[typescript-bot]

Heya @jakebailey, I've started to run the diff-based user code test suite on this PR at 294a3a9. You can monitor the build here.

Update: The results are in!

[typescript-bot]

Heya @jakebailey, I've started to run the extended test suite on this PR at 294a3a9. You can monitor the build here.

[typescript-bot]

Heya @jakebailey, I've started to run the perf test suite on this PR at 294a3a9. You can monitor the build here.

Update: The results are in!

[typescript-bot]

@jakebailey Here are the results of running the user test suite comparing main and refs/pull/52699/merge:

Everything looks good!

[typescript-bot]

Heya @jakebailey, I've run the RWC suite on this PR - assuming you're on the TS core team, you can view the resulting diff here.

[typescript-bot]

@jakebailey
The results of the perf run you requested are in!

Here they are:

Compiler

Comparison Report - main..52699

Metric	main	52699	Delta	Best	Worst	p-value
Angular - node (v18.10.0, x64)
Memory used	359,914k (± 0.02%)	359,847k (± 0.01%)	-67k (- 0.02%)	359,811k	359,932k	p=0.031 n=6
Parse Time	3.90s (± 0.80%)	3.91s (± 0.43%)	~	3.89s	3.94s	p=1.000 n=6
Bind Time	1.17s (± 0.70%)	1.17s (± 0.71%)	~	1.16s	1.18s	p=0.718 n=6
Check Time	8.69s (± 0.96%)	8.72s (± 0.47%)	~	8.69s	8.80s	p=0.065 n=6
Emit Time	7.62s (± 0.68%)	7.60s (± 0.26%)	~	7.58s	7.63s	p=0.520 n=6
Total Time	21.39s (± 0.46%)	21.41s (± 0.29%)	~	21.35s	21.53s	p=0.629 n=6
Compiler-Unions - node (v18.10.0, x64)
Memory used	193,202k (± 1.19%)	193,210k (± 1.24%)	~	192,150k	198,106k	p=0.689 n=6
Parse Time	1.63s (± 1.37%)	1.63s (± 2.45%)	~	1.59s	1.69s	p=1.000 n=6
Bind Time	0.80s (± 0.69%)	0.80s (± 0.69%)	~	0.79s	0.80s	p=1.000 n=6
Check Time	9.74s (± 0.40%)	9.76s (± 0.49%)	~	9.70s	9.82s	p=0.572 n=6
Emit Time	2.80s (± 0.94%)	2.79s (± 0.54%)	~	2.78s	2.81s	p=0.737 n=6
Total Time	14.96s (± 0.40%)	14.97s (± 0.22%)	~	14.93s	15.03s	p=0.469 n=6
Monaco - node (v18.10.0, x64)
Memory used	343,940k (± 0.01%)	343,960k (± 0.01%)	~	343,933k	343,987k	p=0.378 n=6
Parse Time	2.91s (± 0.40%)	2.94s (± 1.40%)	~	2.88s	2.99s	p=0.169 n=6
Bind Time	1.03s (± 1.17%)	1.03s (± 1.50%)	~	1.01s	1.05s	p=0.739 n=6
Check Time	7.05s (± 0.29%)	7.05s (± 0.39%)	~	7.01s	7.08s	p=0.629 n=6
Emit Time	4.32s (± 0.69%)	4.35s (± 0.75%)	~	4.32s	4.40s	p=0.121 n=6
Total Time	15.31s (± 0.30%)	15.37s (± 0.59%)	~	15.25s	15.50s	p=0.261 n=6
TFS - node (v18.10.0, x64)
Memory used	300,354k (± 0.00%)	300,368k (± 0.01%)	~	300,351k	300,390k	p=0.230 n=6
Parse Time	2.26s (± 1.58%)	2.27s (± 1.64%)	~	2.21s	2.30s	p=0.809 n=6
Bind Time	1.17s (± 0.00%)	1.17s (± 0.35%)	~	1.17s	1.18s	p=0.405 n=6
Check Time	6.55s (± 0.32%)	6.55s (± 0.25%)	~	6.53s	6.57s	p=0.623 n=6
Emit Time	3.92s (± 0.66%)	3.93s (± 0.98%)	~	3.89s	3.99s	p=0.747 n=6
Total Time	13.89s (± 0.39%)	13.92s (± 0.40%)	~	13.84s	13.98s	p=0.519 n=6
material-ui - node (v18.10.0, x64)
Memory used	476,773k (± 0.01%)	476,794k (± 0.00%)	~	476,783k	476,823k	p=0.575 n=6
Parse Time	3.50s (± 0.47%)	3.51s (± 0.73%)	~	3.48s	3.54s	p=0.460 n=6
Bind Time	0.96s (± 0.54%)	0.96s (± 0.57%)	~	0.96s	0.97s	p=0.640 n=6
Check Time	17.18s (± 0.46%)	17.19s (± 0.54%)	~	17.08s	17.30s	p=1.000 n=6
Emit Time	0.00s (± 0.00%)	0.00s (± 0.00%)	~	0.00s	0.00s	p=1.000 n=6
Total Time	21.65s (± 0.38%)	21.67s (± 0.37%)	~	21.58s	21.78s	p=0.630 n=6
xstate - node (v18.10.0, x64)
Memory used	548,936k (± 0.01%)	549,029k (± 0.02%)	~	548,893k	549,189k	p=0.066 n=6
Parse Time	4.58s (± 0.33%)	4.56s (± 0.36%)	-0.03s (- 0.62%)	4.54s	4.58s	p=0.023 n=6
Bind Time	1.72s (± 0.68%)	1.72s (± 0.80%)	~	1.70s	1.74s	p=0.742 n=6
Check Time	2.83s (± 1.08%)	2.82s (± 0.93%)	~	2.80s	2.86s	p=0.573 n=6
Emit Time	0.08s (± 0.00%)	0.08s (± 0.00%)	~	0.08s	0.08s	p=1.000 n=6
Total Time	9.22s (± 0.26%)	9.18s (± 0.52%)	~	9.14s	9.25s	p=0.199 n=6
Angular - node (v16.17.1, x64)
Memory used	359,237k (± 0.00%)	359,228k (± 0.01%)	~	359,189k	359,263k	p=0.575 n=6
Parse Time	4.16s (± 0.41%)	4.17s (± 0.24%)	~	4.15s	4.18s	p=0.317 n=6
Bind Time	1.24s (± 0.61%)	1.23s (± 0.95%)	~	1.21s	1.24s	p=0.383 n=6
Check Time	9.47s (± 0.26%)	9.49s (± 0.39%)	~	9.45s	9.55s	p=0.571 n=6
Emit Time	8.04s (± 0.29%)	8.08s (± 0.53%)	+0.05s (+ 0.58%)	8.03s	8.15s	p=0.043 n=6
Total Time	22.91s (± 0.17%)	22.97s (± 0.29%)	~	22.89s	23.07s	p=0.106 n=6
Compiler-Unions - node (v16.17.1, x64)
Memory used	193,761k (± 0.09%)	193,822k (± 0.04%)	~	193,728k	193,929k	p=0.575 n=6
Parse Time	1.79s (± 1.02%)	1.81s (± 0.90%)	~	1.78s	1.83s	p=0.134 n=6
Bind Time	0.84s (± 0.00%)	0.84s (± 0.00%)	~	0.84s	0.84s	p=1.000 n=6
Check Time	10.45s (± 0.79%)	10.45s (± 0.48%)	~	10.41s	10.53s	p=0.936 n=6
Emit Time	3.18s (± 5.24%)	3.06s (± 0.81%)	~	3.02s	3.09s	p=0.293 n=6
Total Time	16.26s (± 1.17%)	16.15s (± 0.38%)	~	16.08s	16.23s	p=0.335 n=6
Monaco - node (v16.17.1, x64)
Memory used	343,224k (± 0.01%)	343,230k (± 0.00%)	~	343,210k	343,241k	p=0.810 n=6
Parse Time	3.15s (± 1.12%)	3.13s (± 0.78%)	~	3.09s	3.16s	p=0.197 n=6
Bind Time	1.11s (± 0.46%)	1.11s (± 0.46%)	~	1.11s	1.12s	p=1.000 n=6
Check Time	7.70s (± 0.21%)	7.73s (± 0.72%)	~	7.64s	7.79s	p=0.169 n=6
Emit Time	4.53s (± 0.41%)	4.52s (± 0.39%)	~	4.49s	4.53s	p=0.684 n=6
Total Time	16.49s (± 0.28%)	16.49s (± 0.41%)	~	16.39s	16.59s	p=0.872 n=6
TFS - node (v16.17.1, x64)
Memory used	299,698k (± 0.00%)	299,712k (± 0.00%)	~	299,691k	299,732k	p=0.054 n=6
Parse Time	2.45s (± 0.72%)	2.46s (± 1.06%)	~	2.42s	2.49s	p=0.369 n=6
Bind Time	1.25s (± 0.44%)	1.25s (± 0.00%)	~	1.25s	1.25s	p=0.071 n=6
Check Time	7.20s (± 0.44%)	7.18s (± 0.54%)	~	7.14s	7.23s	p=0.418 n=6
Emit Time	4.22s (± 0.73%)	4.22s (± 0.75%)	~	4.18s	4.27s	p=0.872 n=6
Total Time	15.13s (± 0.32%)	15.10s (± 0.31%)	~	15.05s	15.18s	p=0.520 n=6
material-ui - node (v16.17.1, x64)
Memory used	476,023k (± 0.00%)	476,026k (± 0.00%)	~	476,019k	476,039k	p=0.748 n=6
Parse Time	3.67s (± 0.50%)	3.67s (± 0.48%)	~	3.66s	3.70s	p=0.564 n=6
Bind Time	1.02s (± 0.40%)	1.02s (± 0.51%)	~	1.01s	1.02s	p=0.595 n=6
Check Time	18.27s (± 0.24%)	18.26s (± 0.59%)	~	18.16s	18.47s	p=0.261 n=6
Emit Time	0.00s (± 0.00%)	0.00s (± 0.00%)	~	0.00s	0.00s	p=1.000 n=6
Total Time	22.96s (± 0.17%)	22.95s (± 0.45%)	~	22.87s	23.15s	p=0.419 n=6
xstate - node (v16.17.1, x64)
Memory used	546,623k (± 0.01%)	546,606k (± 0.01%)	~	546,550k	546,651k	p=0.936 n=6
Parse Time	4.76s (± 0.17%)	4.78s (± 0.63%)	~	4.76s	4.83s	p=0.357 n=6
Bind Time	1.85s (± 0.48%)	1.85s (± 0.28%)	~	1.84s	1.85s	p=0.541 n=6
Check Time	3.07s (± 0.63%)	3.06s (± 0.87%)	~	3.02s	3.09s	p=0.418 n=6
Emit Time	0.09s (± 0.00%)	0.09s (± 0.00%)	~	0.09s	0.09s	p=1.000 n=6
Total Time	9.78s (± 0.19%)	9.78s (± 0.28%)	~	9.75s	9.83s	p=0.871 n=6
Angular - node (v14.15.1, x64)
Memory used	352,867k (± 0.00%)	352,851k (± 0.00%)	~	352,834k	352,864k	p=0.054 n=6
Parse Time	4.23s (± 0.38%)	4.21s (± 0.36%)	-0.02s (- 0.43%)	4.19s	4.23s	p=0.039 n=6
Bind Time	1.28s (± 0.43%)	1.28s (± 0.43%)	~	1.27s	1.28s	p=1.000 n=6
Check Time	9.77s (± 0.48%)	9.77s (± 0.61%)	~	9.69s	9.84s	p=1.000 n=6
Emit Time	8.39s (± 0.79%)	8.38s (± 0.82%)	~	8.32s	8.51s	p=0.809 n=6
Total Time	23.66s (± 0.32%)	23.64s (± 0.42%)	~	23.49s	23.77s	p=1.000 n=6
Compiler-Unions - node (v14.15.1, x64)
Memory used	189,285k (± 0.70%)	188,784k (± 0.08%)	~	188,652k	188,993k	p=0.230 n=6
Parse Time	1.83s (± 0.77%)	1.83s (± 0.60%)	~	1.81s	1.84s	p=1.000 n=6
Bind Time	0.86s (± 0.47%)	0.86s (± 0.87%)	~	0.85s	0.87s	p=1.000 n=6
Check Time	10.47s (± 0.19%)	10.49s (± 0.57%)	~	10.40s	10.55s	p=0.377 n=6
Emit Time	3.45s (± 1.26%)	3.35s (± 4.40%)	~	3.11s	3.51s	p=0.128 n=6
Total Time	16.61s (± 0.35%)	16.52s (± 0.80%)	~	16.31s	16.64s	p=0.422 n=6
Monaco - node (v14.15.1, x64)
Memory used	337,996k (± 0.01%)	337,983k (± 0.01%)	~	337,935k	338,006k	p=0.419 n=6
Parse Time	3.21s (± 0.85%)	3.17s (± 0.43%)	-0.03s (- 0.99%)	3.16s	3.19s	p=0.033 n=6
Bind Time	1.11s (± 0.47%)	1.12s (± 0.67%)	+0.01s (+ 1.05%)	1.11s	1.13s	p=0.020 n=6
Check Time	8.07s (± 0.54%)	8.04s (± 0.35%)	~	8.01s	8.09s	p=0.171 n=6
Emit Time	4.77s (± 0.62%)	4.79s (± 0.80%)	~	4.75s	4.84s	p=0.567 n=6
Total Time	17.16s (± 0.39%)	17.13s (± 0.17%)	~	17.09s	17.17s	p=0.288 n=6
TFS - node (v14.15.1, x64)
Memory used	294,579k (± 0.01%)	294,569k (± 0.00%)	~	294,562k	294,573k	p=0.077 n=6
Parse Time	2.72s (± 0.75%)	2.73s (± 0.49%)	~	2.71s	2.74s	p=0.446 n=6
Bind Time	1.11s (± 0.89%)	1.11s (± 0.57%)	~	1.10s	1.12s	p=1.000 n=6
Check Time	7.56s (± 0.60%)	7.54s (± 0.50%)	~	7.49s	7.59s	p=0.572 n=6
Emit Time	4.63s (± 0.64%)	4.64s (± 1.17%)	~	4.58s	4.72s	p=1.000 n=6
Total Time	16.02s (± 0.41%)	16.02s (± 0.39%)	~	15.96s	16.11s	p=1.000 n=6
material-ui - node (v14.15.1, x64)
Memory used	471,622k (± 0.01%)	471,628k (± 0.01%)	~	471,576k	471,664k	p=0.689 n=6
Parse Time	3.86s (± 0.35%)	3.87s (± 1.19%)	~	3.82s	3.94s	p=0.870 n=6
Bind Time	1.05s (± 0.94%)	1.05s (± 0.39%)	~	1.04s	1.05s	p=0.753 n=6
Check Time	19.06s (± 0.27%)	19.09s (± 0.67%)	~	18.98s	19.28s	p=1.000 n=6
Emit Time	0.00s (± 0.00%)	0.00s (± 0.00%)	~	0.00s	0.00s	p=1.000 n=6
Total Time	23.97s (± 0.27%)	24.01s (± 0.47%)	~	23.88s	24.18s	p=0.809 n=6
xstate - node (v14.15.1, x64)
Memory used	534,741k (± 0.00%)	534,762k (± 0.01%)	~	534,701k	534,824k	p=0.230 n=6
Parse Time	5.11s (± 0.77%)	5.11s (± 1.09%)	~	5.04s	5.18s	p=0.873 n=6
Bind Time	1.70s (± 0.61%)	1.71s (± 0.60%)	~	1.69s	1.72s	p=0.560 n=6
Check Time	3.14s (± 0.39%)	3.15s (± 0.84%)	~	3.12s	3.18s	p=0.805 n=6
Emit Time	0.10s (± 0.00%)	0.10s (± 4.99%)	~	0.10s	0.11s	p=0.174 n=6
Total Time	10.06s (± 0.43%)	10.07s (± 0.77%)	~	9.97s	10.16s	p=0.872 n=6

System

Machine Name	ts-ci-ubuntu
Platform	linux 5.4.0-135-generic
Architecture	x64
Available Memory	16 GB
Available Memory	15 GB
CPUs	4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz

Hosts

• node (v18.10.0, x64)
• node (v16.17.1, x64)
• node (v14.15.1, x64)

Scenarios

• Angular - node (v18.10.0, x64)
• Angular - node (v16.17.1, x64)
• Angular - node (v14.15.1, x64)
• Compiler-Unions - node (v18.10.0, x64)
• Compiler-Unions - node (v16.17.1, x64)
• Compiler-Unions - node (v14.15.1, x64)
• Monaco - node (v18.10.0, x64)
• Monaco - node (v16.17.1, x64)
• Monaco - node (v14.15.1, x64)
• TFS - node (v18.10.0, x64)
• TFS - node (v16.17.1, x64)
• TFS - node (v14.15.1, x64)
• material-ui - node (v18.10.0, x64)
• material-ui - node (v16.17.1, x64)
• material-ui - node (v14.15.1, x64)
• xstate - node (v18.10.0, x64)
• xstate - node (v16.17.1, x64)
• xstate - node (v14.15.1, x64)

Benchmark	Name	Iterations
Current	52699	6
Baseline	main	6

TSServer

Comparison Report - main..52699

Metric	main	52699	Delta	Best	Worst	p-value
Compiler-UnionsTSServer - node (v18.10.0, x64)
Req 1 - updateOpen	2,498ms (± 1.27%)	2,497ms (± 0.89%)	~	2,463ms	2,531ms	p=0.873 n=6
Req 2 - geterr	5,550ms (± 0.85%)	5,570ms (± 0.19%)	~	5,558ms	5,588ms	p=0.936 n=6
Req 3 - references	369ms (± 1.64%)	368ms (± 0.53%)	~	365ms	371ms	p=0.935 n=6
Req 4 - navto	283ms (± 0.80%)	284ms (± 0.62%)	~	282ms	286ms	p=0.567 n=6
Req 5 - completionInfo count	1,356 (± 0.00%)	1,356 (± 0.00%)	~	1,356	1,356	p=1.000 n=6
Req 5 - completionInfo	72ms (± 2.38%)	75ms (± 9.01%)	~	70ms	88ms	p=1.000 n=6
CompilerTSServer - node (v18.10.0, x64)
Req 1 - updateOpen	2,770ms (± 0.37%)	2,758ms (± 0.68%)	~	2,727ms	2,773ms	p=0.199 n=6
Req 2 - geterr	4,065ms (± 0.45%)	4,057ms (± 0.49%)	~	4,036ms	4,089ms	p=0.689 n=6
Req 3 - references	370ms (± 0.41%)	367ms (± 0.79%)	~	363ms	370ms	p=0.063 n=6
Req 4 - navto	294ms (± 0.91%)	293ms (± 0.61%)	~	291ms	296ms	p=0.745 n=6
Req 5 - completionInfo count	1,518 (± 0.00%)	1,518 (± 0.00%)	~	1,518	1,518	p=1.000 n=6
Req 5 - completionInfo	69ms (± 8.24%)	67ms (± 1.58%)	~	65ms	68ms	p=1.000 n=6
xstateTSServer - node (v18.10.0, x64)
Req 1 - updateOpen	3,488ms (± 0.77%)	3,501ms (± 0.59%)	~	3,473ms	3,528ms	p=0.378 n=6
Req 2 - geterr	1,646ms (± 0.85%)	1,645ms (± 0.93%)	~	1,616ms	1,661ms	p=0.810 n=6
Req 3 - references	104ms (± 1.00%)	103ms (± 0.73%)	~	102ms	104ms	p=0.351 n=6
Req 4 - navto	356ms (± 0.74%)	363ms (± 2.16%)	~	355ms	376ms	p=0.077 n=6
Req 5 - completionInfo count	3,175 (± 0.00%)	3,175 (± 0.00%)	~	3,175	3,175	p=1.000 n=6
Req 5 - completionInfo	451ms (± 1.23%)	449ms (± 0.64%)	~	445ms	453ms	p=0.747 n=6
Compiler-UnionsTSServer - node (v16.17.1, x64)
Req 1 - updateOpen	2,762ms (± 0.40%)	2,784ms (± 0.73%)	+22ms (+ 0.81%)	2,767ms	2,823ms	p=0.044 n=6
Req 2 - geterr	5,895ms (± 0.15%)	5,945ms (± 0.95%)	~	5,868ms	6,033ms	p=0.066 n=6
Req 3 - references	376ms (± 0.57%)	375ms (± 1.06%)	~	370ms	380ms	p=1.000 n=6
Req 4 - navto	280ms (± 0.71%)	278ms (± 0.87%)	~	275ms	281ms	p=0.188 n=6
Req 5 - completionInfo count	1,356 (± 0.00%)	1,356 (± 0.00%)	~	1,356	1,356	p=1.000 n=6
Req 5 - completionInfo	82ms (± 4.58%)	80ms (± 4.42%)	~	76ms	85ms	p=0.413 n=6
CompilerTSServer - node (v16.17.1, x64)
Req 1 - updateOpen	2,915ms (± 0.47%)	2,911ms (± 0.53%)	~	2,893ms	2,931ms	p=0.574 n=6
Req 2 - geterr	4,402ms (± 0.62%)	4,416ms (± 0.15%)	~	4,407ms	4,425ms	p=0.297 n=6
Req 3 - references	380ms (± 1.06%)	379ms (± 1.03%)	~	375ms	385ms	p=1.000 n=6
Req 4 - navto	286ms (± 0.56%)	287ms (± 0.64%)	~	284ms	289ms	p=0.514 n=6
Req 5 - completionInfo count	1,518 (± 0.00%)	1,518 (± 0.00%)	~	1,518	1,518	p=1.000 n=6
Req 5 - completionInfo	71ms (± 1.14%)	71ms (± 0.57%)	~	71ms	72ms	p=0.584 n=6
xstateTSServer - node (v16.17.1, x64)
Req 1 - updateOpen	3,627ms (± 0.28%)	3,629ms (± 0.34%)	~	3,605ms	3,639ms	p=0.630 n=6
Req 2 - geterr	1,825ms (± 1.10%)	1,815ms (± 0.94%)	~	1,786ms	1,834ms	p=0.229 n=6
Req 3 - references	113ms (± 2.24%)	113ms (± 0.46%)	~	113ms	114ms	p=0.934 n=6
Req 4 - navto	341ms (± 0.89%)	346ms (± 1.01%)	+5ms (+ 1.52%)	340ms	349ms	p=0.028 n=6
Req 5 - completionInfo count	3,175 (± 0.00%)	3,175 (± 0.00%)	~	3,175	3,175	p=1.000 n=6
Req 5 - completionInfo	452ms (± 1.48%)	457ms (± 0.91%)	~	452ms	462ms	p=0.124 n=6
Compiler-UnionsTSServer - node (v14.15.1, x64)
Req 1 - updateOpen	2,887ms (± 0.27%)	2,888ms (± 0.48%)	~	2,872ms	2,908ms	p=1.000 n=6
Req 2 - geterr	6,313ms (± 1.13%)	6,329ms (± 1.24%)	~	6,237ms	6,428ms	p=0.936 n=6
Req 3 - references	391ms (± 0.21%)	392ms (± 0.80%)	~	387ms	396ms	p=0.406 n=6
Req 4 - navto	279ms (± 1.17%)	282ms (± 1.89%)	~	277ms	291ms	p=0.288 n=6
Req 5 - completionInfo count	1,356 (± 0.00%)	1,356 (± 0.00%)	~	1,356	1,356	p=1.000 n=6
Req 5 - completionInfo	97ms (± 8.38%)	92ms (±10.35%)	~	81ms	101ms	p=0.617 n=6
CompilerTSServer - node (v14.15.1, x64)
Req 1 - updateOpen	3,048ms (± 0.82%)	3,041ms (± 1.12%)	~	3,001ms	3,087ms	p=0.575 n=6
Req 2 - geterr	4,721ms (± 0.43%)	4,712ms (± 0.20%)	~	4,699ms	4,725ms	p=0.378 n=6
Req 3 - references	407ms (± 1.48%)	407ms (± 1.41%)	~	400ms	416ms	p=1.000 n=6
Req 4 - navto	291ms (± 0.97%)	294ms (± 1.04%)	~	290ms	298ms	p=0.092 n=6
Req 5 - completionInfo count	1,518 (± 0.00%)	1,518 (± 0.00%)	~	1,518	1,518	p=1.000 n=6
Req 5 - completionInfo	81ms (± 4.34%)	84ms (± 5.02%)	~	80ms	88ms	p=0.186 n=6
xstateTSServer - node (v14.15.1, x64)
Req 1 - updateOpen	3,950ms (± 0.41%)	3,928ms (± 0.66%)	~	3,902ms	3,978ms	p=0.065 n=6
Req 2 - geterr	1,800ms (± 1.48%)	1,791ms (± 1.80%)	~	1,750ms	1,847ms	p=0.575 n=6
Req 3 - references	131ms (± 2.33%)	130ms (± 3.20%)	~	124ms	136ms	p=0.744 n=6
Req 4 - navto	375ms (± 0.32%)	375ms (± 0.40%)	~	372ms	376ms	p=0.563 n=6
Req 5 - completionInfo count	3,175 (± 0.00%)	3,175 (± 0.00%)	~	3,175	3,175	p=1.000 n=6
Req 5 - completionInfo	471ms (± 2.55%)	468ms (± 1.75%)	~	458ms	480ms	p=0.521 n=6

System

Machine Name	ts-ci-ubuntu
Platform	linux 5.4.0-135-generic
Architecture	x64
Available Memory	16 GB
Available Memory	15 GB
CPUs	4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz

Hosts

• node (v18.10.0, x64)
• node (v16.17.1, x64)
• node (v14.15.1, x64)

Scenarios

• Compiler-UnionsTSServer - node (v18.10.0, x64)
• Compiler-UnionsTSServer - node (v16.17.1, x64)
• Compiler-UnionsTSServer - node (v14.15.1, x64)
• CompilerTSServer - node (v18.10.0, x64)
• CompilerTSServer - node (v16.17.1, x64)
• CompilerTSServer - node (v14.15.1, x64)
• xstateTSServer - node (v18.10.0, x64)
• xstateTSServer - node (v16.17.1, x64)
• xstateTSServer - node (v14.15.1, x64)

Benchmark	Name	Iterations
Current	52699	6
Baseline	main	6

Startup

Comparison Report - main..52699

Metric	main	52699	Delta	Best	Worst	p-value
tsc-startup - node (v16.17.1, x64)
Execution time	141.98ms (± 0.19%)	142.16ms (± 0.17%)	+0.18ms (+ 0.13%)	141.49ms	144.38ms	p=0.000 n=600
tsserver-startup - node (v16.17.1, x64)
Execution time	226.36ms (± 0.21%)	226.47ms (± 0.17%)	+0.12ms (+ 0.05%)	225.60ms	232.39ms	p=0.000 n=600
tsserverlibrary-startup - node (v16.17.1, x64)
Execution time	228.00ms (± 0.18%)	228.24ms (± 0.15%)	+0.24ms (+ 0.11%)	227.24ms	232.55ms	p=0.000 n=600
typescript-startup - node (v16.17.1, x64)
Execution time	208.89ms (± 0.19%)	209.18ms (± 0.19%)	+0.29ms (+ 0.14%)	208.17ms	215.92ms	p=0.000 n=600

System

Machine Name	ts-ci-ubuntu
Platform	linux 5.4.0-135-generic
Architecture	x64
Available Memory	16 GB
Available Memory	15 GB
CPUs	4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz

Hosts

• node (v16.17.1, x64)

Scenarios

• tsc-startup - node (v16.17.1, x64)
• tsserver-startup - node (v16.17.1, x64)
• tsserverlibrary-startup - node (v16.17.1, x64)
• typescript-startup - node (v16.17.1, x64)

Benchmark	Name	Iterations
Current	52699	6
Baseline	main	6

Developer Information:

Download Benchmark

[typescript-bot]

@jakebailey Here are the results of running the top-repos suite comparing main and refs/pull/52699/merge:

Everything looks good!