Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve error for unclosed imports and exports #54634

Merged
merged 3 commits into from
Jun 29, 2023
Merged

Improve error for unclosed imports and exports #54634

merged 3 commits into from
Jun 29, 2023

Conversation

Jack-Works
Copy link
Contributor

@Jack-Works Jack-Works commented Jun 13, 2023 •
edited
Loading

this fix is picked from #49297
before:
image

after:
image

@typescript-bot typescript-bot added the For Uncommitted Bug PR for untriaged, rejected, closed or missing bug label Jun 13, 2023
@typescript-bot
Copy link
Collaborator

This PR doesn't have any linked issues. Please open an issue that references this PR. From there we can discuss and prioritise.

@sandersn sandersn self-assigned this Jun 28, 2023
@sandersn sandersn requested review from sandersn and gabritto June 28, 2023 17:49
@sandersn
Copy link
Member

@typescript-bot perf test this

@typescript-bot
Copy link
Collaborator

typescript-bot commented Jun 28, 2023 •
edited
Loading

Heya @sandersn, I've started to run the perf test suite on this PR at 27d107e. You can monitor the build here.

Update: The results are in!

sandersn
sandersn approved these changes Jun 28, 2023
View reviewed changes
Copy link
Member

@sandersn sandersn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me as long as the lookahead doesn't hurt performance (and I doubt it will since ParsingContext.ImportOrExportSpecifiers doesn't come up much)

@typescript-bot
Copy link
Collaborator

@sandersn
The results of the perf run you requested are in!

Here they are:

Compiler

Comparison Report - main..54634
Metric main 54634 Delta Best Worst p-value
Angular - node (v18.10.0, x64)
Memory used 366,753k (± 0.01%) 366,748k (± 0.01%) ~ 366,710k 366,777k p=0.810 n=6
Parse Time 3.46s (± 0.60%) 3.40s (± 0.51%) -0.06s (- 1.69%) 3.38s 3.43s p=0.008 n=6
Bind Time 1.12s (± 0.67%) 1.11s (± 0.75%) ~ 1.11s 1.13s p=0.172 n=6
Check Time 8.88s (± 0.44%) 8.82s (± 0.19%) -0.06s (- 0.73%) 8.80s 8.84s p=0.013 n=6
Emit Time 7.54s (± 0.90%) 7.50s (± 0.35%) ~ 7.47s 7.53s p=0.335 n=6
Total Time 21.00s (± 0.52%) 20.83s (± 0.19%) -0.17s (- 0.81%) 20.77s 20.88s p=0.013 n=6
Compiler-Unions - node (v18.10.0, x64)
Memory used 193,823k (± 1.63%) 190,965k (± 0.02%) ~ 190,930k 191,000k p=0.378 n=6
Parse Time 1.50s (± 0.91%) 1.49s (± 0.55%) -0.02s (- 1.22%) 1.48s 1.50s p=0.032 n=6
Bind Time 0.77s (± 0.00%) 0.77s (± 0.72%) ~ 0.76s 0.77s p=0.071 n=6
Check Time 9.49s (± 0.82%) 9.46s (± 0.85%) ~ 9.39s 9.60s p=0.373 n=6
Emit Time 2.76s (± 0.68%) 2.77s (± 1.31%) ~ 2.73s 2.83s p=0.747 n=6
Total Time 14.52s (± 0.45%) 14.48s (± 0.65%) ~ 14.38s 14.64s p=0.418 n=6
Monaco - node (v18.10.0, x64)
Memory used 346,806k (± 0.01%) 346,793k (± 0.01%) ~ 346,773k 346,827k p=0.689 n=6
Parse Time 2.60s (± 0.97%) 2.57s (± 0.58%) ~ 2.55s 2.59s p=0.086 n=6
Bind Time 1.01s (± 1.25%) 1.00s (± 0.63%) ~ 0.99s 1.01s p=0.090 n=6
Check Time 7.22s (± 0.48%) 7.16s (± 0.26%) -0.06s (- 0.85%) 7.14s 7.19s p=0.010 n=6
Emit Time 4.26s (± 1.01%) 4.26s (± 0.58%) ~ 4.23s 4.30s p=1.000 n=6
Total Time 15.10s (± 0.64%) 15.00s (± 0.24%) ~ 14.96s 15.06s p=0.092 n=6
TFS - node (v18.10.0, x64)
Memory used 300,881k (± 0.01%) 300,877k (± 0.00%) ~ 300,865k 300,889k p=0.748 n=6
Parse Time 2.09s (± 1.16%) 2.06s (± 0.89%) ~ 2.04s 2.09s p=0.051 n=6
Bind Time 1.14s (± 0.73%) 1.13s (± 0.67%) -0.02s (- 1.46%) 1.12s 1.14s p=0.009 n=6
Check Time 6.68s (± 0.21%) 6.67s (± 0.47%) ~ 6.65s 6.73s p=0.145 n=6
Emit Time 3.86s (± 0.69%) 3.85s (± 1.11%) ~ 3.81s 3.93s p=0.460 n=6
Total Time 13.78s (± 0.20%) 13.71s (± 0.32%) -0.08s (- 0.54%) 13.63s 13.76s p=0.010 n=6
material-ui - node (v18.10.0, x64)
Memory used 482,455k (± 0.01%) 482,438k (± 0.01%) ~ 482,326k 482,511k p=1.000 n=6
Parse Time 3.13s (± 0.44%) 3.11s (± 0.44%) -0.02s (- 0.64%) 3.10s 3.14s p=0.042 n=6
Bind Time 0.92s (± 1.44%) 0.91s (± 1.32%) ~ 0.90s 0.93s p=0.240 n=6
Check Time 17.44s (± 0.43%) 17.25s (± 0.42%) -0.19s (- 1.09%) 17.19s 17.38s p=0.010 n=6
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) ~ 0.00s 0.00s p=1.000 n=6
Total Time 21.50s (± 0.38%) 21.28s (± 0.28%) -0.22s (- 1.02%) 21.21s 21.38s p=0.005 n=6
xstate - node (v18.10.0, x64)
Memory used 563,567k (± 0.02%) 563,534k (± 0.02%) ~ 563,484k 563,703k p=0.378 n=6
Parse Time 3.85s (± 0.75%) 3.84s (± 0.48%) ~ 3.82s 3.87s p=0.870 n=6
Bind Time 1.64s (± 0.50%) 1.63s (± 0.60%) -0.02s (- 0.91%) 1.62s 1.64s p=0.022 n=6
Check Time 2.80s (± 0.93%) 2.80s (± 0.95%) ~ 2.75s 2.83s p=0.808 n=6
Emit Time 0.08s (± 0.00%) 0.08s (± 0.00%) ~ 0.08s 0.08s p=1.000 n=6
Total Time 8.37s (± 0.42%) 8.34s (± 0.28%) ~ 8.31s 8.37s p=0.108 n=6
Angular - node (v16.17.1, x64)
Memory used 366,124k (± 0.01%) 366,136k (± 0.01%) ~ 366,103k 366,196k p=0.810 n=6
Parse Time 3.58s (± 0.23%) 3.57s (± 0.25%) -0.01s (- 0.42%) 3.56s 3.58s p=0.021 n=6
Bind Time 1.18s (± 0.44%) 1.18s (± 0.44%) ~ 1.17s 1.18s p=0.069 n=6
Check Time 9.65s (± 0.57%) 9.64s (± 0.59%) ~ 9.57s 9.73s p=0.809 n=6
Emit Time 8.01s (± 0.83%) 7.96s (± 0.15%) ~ 7.95s 7.98s p=0.244 n=6
Total Time 22.42s (± 0.55%) 22.34s (± 0.28%) ~ 22.28s 22.44s p=0.296 n=6
Compiler-Unions - node (v16.17.1, x64)
Memory used 192,825k (± 0.02%) 192,801k (± 0.02%) ~ 192,713k 192,836k p=0.296 n=6
Parse Time 1.60s (± 1.07%) 1.57s (± 1.51%) -0.03s (- 1.98%) 1.54s 1.60s p=0.043 n=6
Bind Time 0.83s (± 0.62%) 0.81s (± 0.63%) -0.01s (- 1.61%) 0.81s 0.82s p=0.009 n=6
Check Time 10.17s (± 0.56%) 10.13s (± 0.36%) ~ 10.09s 10.17s p=0.687 n=6
Emit Time 3.04s (± 1.18%) 3.01s (± 0.59%) ~ 2.98s 3.03s p=0.064 n=6
Total Time 15.63s (± 0.54%) 15.53s (± 0.39%) -0.10s (- 0.67%) 15.44s 15.59s p=0.020 n=6
Monaco - node (v16.17.1, x64)
Memory used 346,064k (± 0.01%) 346,069k (± 0.00%) ~ 346,051k 346,096k p=1.000 n=6
Parse Time 2.74s (± 0.45%) 2.72s (± 0.00%) -0.02s (- 0.91%) 2.72s 2.72s p=0.003 n=6
Bind Time 1.09s (± 0.00%) 1.09s (± 0.75%) ~ 1.08s 1.10s p=0.290 n=6
Check Time 7.89s (± 0.38%) 7.86s (± 0.33%) -0.04s (- 0.51%) 7.82s 7.88s p=0.030 n=6
Emit Time 4.48s (± 0.61%) 4.45s (± 0.83%) ~ 4.41s 4.52s p=0.104 n=6
Total Time 16.21s (± 0.27%) 16.11s (± 0.32%) -0.09s (- 0.59%) 16.06s 16.20s p=0.020 n=6
TFS - node (v16.17.1, x64)
Memory used 300,215k (± 0.01%) 300,213k (± 0.01%) ~ 300,195k 300,232k p=0.689 n=6
Parse Time 2.19s (± 0.75%) 2.17s (± 0.63%) -0.02s (- 0.91%) 2.16s 2.20s p=0.042 n=6
Bind Time 1.24s (± 0.83%) 1.24s (± 0.66%) ~ 1.23s 1.25s p=0.270 n=6
Check Time 7.35s (± 0.61%) 7.31s (± 0.35%) ~ 7.27s 7.34s p=0.106 n=6
Emit Time 4.35s (± 0.51%) 4.34s (± 0.27%) ~ 4.32s 4.35s p=0.326 n=6
Total Time 15.14s (± 0.59%) 15.05s (± 0.21%) ~ 15.02s 15.10s p=0.064 n=6
material-ui - node (v16.17.1, x64)
Memory used 481,706k (± 0.01%) 481,688k (± 0.01%) ~ 481,641k 481,746k p=0.378 n=6
Parse Time 3.27s (± 0.27%) 3.26s (± 0.19%) ~ 3.25s 3.27s p=0.070 n=6
Bind Time 0.96s (± 0.54%) 0.95s (± 0.54%) -0.01s (- 1.05%) 0.94s 0.95s p=0.018 n=6
Check Time 18.34s (± 0.65%) 18.21s (± 0.46%) -0.12s (- 0.67%) 18.08s 18.34s p=0.037 n=6
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) ~ 0.00s 0.00s p=1.000 n=6
Total Time 22.56s (± 0.56%) 22.43s (± 0.36%) -0.14s (- 0.61%) 22.31s 22.56s p=0.030 n=6
xstate - node (v16.17.1, x64)
Memory used 561,181k (± 0.02%) 561,216k (± 0.02%) ~ 561,059k 561,383k p=0.810 n=6
Parse Time 4.03s (± 0.44%) 3.99s (± 0.27%) -0.04s (- 0.99%) 3.98s 4.01s p=0.008 n=6
Bind Time 1.75s (± 0.60%) 1.74s (± 1.07%) ~ 1.72s 1.77s p=0.251 n=6
Check Time 3.06s (± 0.48%) 3.05s (± 0.45%) ~ 3.02s 3.06s p=0.304 n=6
Emit Time 0.09s (± 4.45%) 0.09s (± 5.53%) ~ 0.09s 0.10s p=1.000 n=6
Total Time 8.93s (± 0.15%) 8.86s (± 0.31%) -0.07s (- 0.77%) 8.83s 8.90s p=0.005 n=6
Angular - node (v14.21.3, x64)
Memory used 360,100k (± 0.01%) 360,106k (± 0.01%) ~ 360,074k 360,155k p=0.873 n=6
Parse Time 3.68s (± 0.53%) 3.69s (± 0.63%) ~ 3.66s 3.72s p=0.328 n=6
Bind Time 1.23s (± 0.98%) 1.22s (± 0.62%) -0.02s (- 1.22%) 1.21s 1.23s p=0.045 n=6
Check Time 10.11s (± 0.38%) 10.08s (± 0.52%) ~ 10.01s 10.14s p=0.466 n=6
Emit Time 8.42s (± 0.68%) 8.33s (± 0.31%) -0.09s (- 1.05%) 8.29s 8.36s p=0.037 n=6
Total Time 23.43s (± 0.33%) 23.31s (± 0.32%) -0.12s (- 0.52%) 23.20s 23.43s p=0.020 n=6
Compiler-Unions - node (v14.21.3, x64)
Memory used 188,155k (± 0.01%) 188,126k (± 0.03%) ~ 188,035k 188,180k p=0.377 n=6
Parse Time 1.63s (± 0.50%) 1.62s (± 0.65%) ~ 1.60s 1.63s p=0.078 n=6
Bind Time 0.85s (± 0.00%) 0.84s (± 0.48%) -0.01s (- 0.98%) 0.84s 0.85s p=0.007 n=6
Check Time 10.34s (± 0.45%) 10.24s (± 0.56%) -0.09s (- 0.89%) 10.16s 10.31s p=0.016 n=6
Emit Time 3.14s (± 0.81%) 3.14s (± 1.03%) ~ 3.11s 3.19s p=0.935 n=6
Total Time 15.95s (± 0.33%) 15.85s (± 0.51%) -0.11s (- 0.68%) 15.72s 15.91s p=0.030 n=6
Monaco - node (v14.21.3, x64)
Memory used 341,191k (± 0.01%) 341,182k (± 0.00%) ~ 341,167k 341,193k p=0.936 n=6
Parse Time 2.83s (± 0.55%) 2.81s (± 0.27%) ~ 2.80s 2.82s p=0.050 n=6
Bind Time 1.11s (± 0.73%) 1.12s (± 0.67%) ~ 1.11s 1.13s p=0.082 n=6
Check Time 8.25s (± 0.37%) 8.19s (± 0.58%) ~ 8.14s 8.27s p=0.077 n=6
Emit Time 4.71s (± 0.78%) 4.70s (± 0.99%) ~ 4.65s 4.78s p=0.573 n=6
Total Time 16.90s (± 0.34%) 16.82s (± 0.47%) ~ 16.71s 16.94s p=0.075 n=6
TFS - node (v14.21.3, x64)
Memory used 295,306k (± 0.00%) 295,309k (± 0.00%) ~ 295,303k 295,313k p=0.422 n=6
Parse Time 2.41s (± 0.93%) 2.38s (± 0.93%) ~ 2.36s 2.41s p=0.062 n=6
Bind Time 1.07s (± 0.48%) 1.07s (± 0.48%) ~ 1.06s 1.07s p=1.000 n=6
Check Time 7.65s (± 0.36%) 7.63s (± 0.49%) ~ 7.58s 7.69s p=0.469 n=6
Emit Time 4.31s (± 0.78%) 4.29s (± 0.50%) ~ 4.26s 4.32s p=0.295 n=6
Total Time 15.43s (± 0.46%) 15.37s (± 0.39%) ~ 15.31s 15.48s p=0.260 n=6
material-ui - node (v14.21.3, x64)
Memory used 477,166k (± 0.00%) 477,165k (± 0.00%) ~ 477,143k 477,188k p=1.000 n=6
Parse Time 3.36s (± 0.42%) 3.32s (± 0.25%) -0.04s (- 1.09%) 3.31s 3.33s p=0.005 n=6
Bind Time 1.01s (± 0.00%) 1.00s (± 0.00%) -0.01s (- 0.99%) 1.00s 1.00s p=0.001 n=6
Check Time 19.40s (± 0.72%) 19.16s (± 0.35%) -0.24s (- 1.25%) 19.06s 19.24s p=0.008 n=6
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) ~ 0.00s 0.00s p=1.000 n=6
Total Time 23.77s (± 0.60%) 23.48s (± 0.33%) -0.29s (- 1.23%) 23.37s 23.57s p=0.005 n=6
xstate - node (v14.21.3, x64)
Memory used 550,174k (± 0.01%) 550,179k (± 0.00%) ~ 550,155k 550,192k p=0.298 n=6
Parse Time 4.25s (± 0.18%) 4.22s (± 0.38%) -0.03s (- 0.71%) 4.20s 4.24s p=0.007 n=6
Bind Time 1.68s (± 1.15%) 1.67s (± 0.59%) ~ 1.65s 1.68s p=0.156 n=6
Check Time 3.14s (± 0.66%) 3.13s (± 0.47%) ~ 3.10s 3.14s p=0.871 n=6
Emit Time 0.09s (± 0.00%) 0.09s (± 0.00%) ~ 0.09s 0.09s p=1.000 n=6
Total Time 9.15s (± 0.32%) 9.11s (± 0.27%) -0.05s (- 0.51%) 9.07s 9.14s p=0.030 n=6
System
Machine Namets-ci-ubuntu
Platformlinux 5.4.0-148-generic
Architecturex64
Available Memory16 GB
Available Memory15 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v18.10.0, x64)
  • node (v16.17.1, x64)
  • node (v14.21.3, x64)
Scenarios
  • Angular - node (v18.10.0, x64)
  • Angular - node (v16.17.1, x64)
  • Angular - node (v14.21.3, x64)
  • Compiler-Unions - node (v18.10.0, x64)
  • Compiler-Unions - node (v16.17.1, x64)
  • Compiler-Unions - node (v14.21.3, x64)
  • Monaco - node (v18.10.0, x64)
  • Monaco - node (v16.17.1, x64)
  • Monaco - node (v14.21.3, x64)
  • TFS - node (v18.10.0, x64)
  • TFS - node (v16.17.1, x64)
  • TFS - node (v14.21.3, x64)
  • material-ui - node (v18.10.0, x64)
  • material-ui - node (v16.17.1, x64)
  • material-ui - node (v14.21.3, x64)
  • xstate - node (v18.10.0, x64)
  • xstate - node (v16.17.1, x64)
  • xstate - node (v14.21.3, x64)
Benchmark Name Iterations
Current 54634 6
Baseline main 6

TSServer

Comparison Report - main..54634
Metric main 54634 Delta Best Worst p-value
Compiler-UnionsTSServer - node (v18.10.0, x64)
Req 1 - updateOpen 2,575ms (± 0.93%) 2,542ms (± 0.47%) -33ms (- 1.27%) 2,527ms 2,556ms p=0.020 n=6
Req 2 - geterr 5,373ms (± 0.79%) 5,352ms (± 0.70%) ~ 5,311ms 5,416ms p=0.298 n=6
Req 3 - references 342ms (± 1.15%) 342ms (± 0.86%) ~ 337ms 346ms p=0.628 n=6
Req 4 - navto 288ms (± 0.42%) 286ms (± 0.36%) ~ 285ms 288ms p=0.084 n=6
Req 5 - completionInfo count 1,356 (± 0.00%) 1,356 (± 0.00%) ~ 1,356 1,356 p=1.000 n=6
Req 5 - completionInfo 82ms (± 3.73%) 83ms (± 2.15%) ~ 81ms 85ms p=0.934 n=6
CompilerTSServer - node (v18.10.0, x64)
Req 1 - updateOpen 2,655ms (± 1.15%) 2,654ms (± 0.98%) ~ 2,609ms 2,678ms p=0.575 n=6
Req 2 - geterr 4,136ms (± 1.98%) 4,098ms (± 0.32%) ~ 4,085ms 4,117ms p=0.295 n=6
Req 3 - references 349ms (± 0.97%) 349ms (± 0.47%) ~ 346ms 350ms p=0.747 n=6
Req 4 - navto 287ms (± 0.41%) 287ms (± 0.51%) ~ 286ms 290ms p=0.666 n=6
Req 5 - completionInfo count 1,518 (± 0.00%) 1,518 (± 0.00%) ~ 1,518 1,518 p=1.000 n=6
Req 5 - completionInfo 71ms (± 1.26%) 70ms (± 0.73%) ~ 70ms 71ms p=0.190 n=6
xstateTSServer - node (v18.10.0, x64)
Req 1 - updateOpen 3,112ms (± 0.40%) 3,100ms (± 0.44%) ~ 3,080ms 3,118ms p=0.148 n=6
Req 2 - geterr 1,604ms (± 0.64%) 1,593ms (± 0.78%) ~ 1,578ms 1,610ms p=0.172 n=6
Req 3 - references 112ms (± 0.92%) 113ms (± 1.07%) ~ 111ms 114ms p=0.675 n=6
Req 4 - navto 370ms (± 0.44%) 370ms (± 0.91%) ~ 368ms 377ms p=0.514 n=6
Req 5 - completionInfo count 2,872 (± 0.00%) 2,872 (± 0.00%) ~ 2,872 2,872 p=1.000 n=6
Req 5 - completionInfo 378ms (± 1.50%) 376ms (± 2.10%) ~ 363ms 383ms p=0.571 n=6
Compiler-UnionsTSServer - node (v16.17.1, x64)
Req 1 - updateOpen 2,669ms (± 1.42%) 2,637ms (± 0.66%) ~ 2,619ms 2,664ms p=0.092 n=6
Req 2 - geterr 5,988ms (± 1.75%) 6,023ms (± 0.30%) ~ 6,004ms 6,054ms p=1.000 n=6
Req 3 - references 354ms (± 0.43%) 354ms (± 0.59%) ~ 351ms 356ms p=0.807 n=6
Req 4 - navto 285ms (± 0.69%) 288ms (± 1.75%) ~ 281ms 294ms p=0.465 n=6
Req 5 - completionInfo count 1,356 (± 0.00%) 1,356 (± 0.00%) ~ 1,356 1,356 p=1.000 n=6
Req 5 - completionInfo 89ms (± 8.89%) 93ms (± 0.59%) ~ 92ms 93ms p=0.476 n=6
CompilerTSServer - node (v16.17.1, x64)
Req 1 - updateOpen 2,853ms (± 0.69%) 2,826ms (± 0.44%) -27ms (- 0.96%) 2,813ms 2,849ms p=0.045 n=6
Req 2 - geterr 4,680ms (± 0.37%) 4,675ms (± 0.36%) ~ 4,661ms 4,703ms p=0.572 n=6
Req 3 - references 365ms (± 0.48%) 364ms (± 0.68%) ~ 361ms 368ms p=0.373 n=6
Req 4 - navto 285ms (± 0.52%) 283ms (± 0.99%) ~ 278ms 286ms p=0.088 n=6
Req 5 - completionInfo count 1,518 (± 0.00%) 1,518 (± 0.00%) ~ 1,518 1,518 p=1.000 n=6
Req 5 - completionInfo 75ms (± 1.19%) 75ms (± 0.54%) ~ 75ms 76ms p=0.787 n=6
xstateTSServer - node (v16.17.1, x64)
Req 1 - updateOpen 3,266ms (± 0.73%) 3,230ms (± 0.20%) -35ms (- 1.08%) 3,221ms 3,238ms p=0.045 n=6
Req 2 - geterr 1,751ms (± 1.13%) 1,734ms (± 1.49%) ~ 1,693ms 1,757ms p=0.630 n=6
Req 3 - references 127ms (± 6.77%) 126ms (± 6.65%) ~ 121ms 143ms p=0.655 n=6
Req 4 - navto 357ms (± 0.72%) 353ms (± 0.34%) -4ms (- 1.17%) 351ms 354ms p=0.015 n=6
Req 5 - completionInfo count 2,872 (± 0.00%) 2,872 (± 0.00%) ~ 2,872 2,872 p=1.000 n=6
Req 5 - completionInfo 410ms (± 1.80%) 409ms (± 1.48%) ~ 401ms 418ms p=1.000 n=6
Compiler-UnionsTSServer - node (v14.21.3, x64)
Req 1 - updateOpen 2,822ms (± 0.59%) 2,791ms (± 0.68%) -31ms (- 1.09%) 2,766ms 2,816ms p=0.025 n=6
Req 2 - geterr 6,211ms (± 0.45%) 6,187ms (± 0.35%) ~ 6,155ms 6,212ms p=0.128 n=6
Req 3 - references 361ms (± 0.67%) 362ms (± 0.87%) ~ 357ms 366ms p=0.685 n=6
Req 4 - navto 292ms (± 0.40%) 291ms (± 0.19%) -1ms (- 0.46%) 290ms 291ms p=0.025 n=6
Req 5 - completionInfo count 1,356 (± 0.00%) 1,356 (± 0.00%) ~ 1,356 1,356 p=1.000 n=6
Req 5 - completionInfo 102ms (± 6.17%) 104ms (± 0.50%) ~ 103ms 104ms p=0.928 n=6
CompilerTSServer - node (v14.21.3, x64)
Req 1 - updateOpen 2,990ms (± 0.45%) 2,972ms (± 0.41%) -19ms (- 0.62%) 2,951ms 2,986ms p=0.031 n=6
Req 2 - geterr 4,556ms (± 0.61%) 4,539ms (± 0.85%) ~ 4,487ms 4,585ms p=0.575 n=6
Req 3 - references 377ms (± 0.52%) 377ms (± 0.36%) ~ 375ms 379ms p=1.000 n=6
Req 4 - navto 300ms (± 0.49%) 298ms (± 0.46%) ~ 296ms 300ms p=0.073 n=6
Req 5 - completionInfo count 1,518 (± 0.00%) 1,518 (± 0.00%) ~ 1,518 1,518 p=1.000 n=6
Req 5 - completionInfo 77ms (± 0.53%) 77ms (± 2.54%) ~ 74ms 80ms p=0.245 n=6
xstateTSServer - node (v14.21.3, x64)
Req 1 - updateOpen 3,491ms (± 0.72%) 3,475ms (± 0.91%) ~ 3,425ms 3,505ms p=0.298 n=6
Req 2 - geterr 1,856ms (± 1.09%) 1,853ms (± 1.31%) ~ 1,816ms 1,886ms p=0.936 n=6
Req 3 - references 152ms (± 6.75%) 151ms (± 8.53%) ~ 132ms 160ms p=0.571 n=6
Req 4 - navto 397ms (± 0.37%) 396ms (± 0.80%) ~ 392ms 401ms p=0.629 n=6
Req 5 - completionInfo count 2,872 (± 0.00%) 2,872 (± 0.00%) ~ 2,872 2,872 p=1.000 n=6
Req 5 - completionInfo 432ms (± 2.81%) 436ms (± 1.26%) ~ 427ms 443ms p=0.297 n=6
System
Machine Namets-ci-ubuntu
Platformlinux 5.4.0-148-generic
Architecturex64
Available Memory16 GB
Available Memory15 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v18.10.0, x64)
  • node (v16.17.1, x64)
  • node (v14.21.3, x64)
Scenarios
  • Compiler-UnionsTSServer - node (v18.10.0, x64)
  • Compiler-UnionsTSServer - node (v16.17.1, x64)
  • Compiler-UnionsTSServer - node (v14.21.3, x64)
  • CompilerTSServer - node (v18.10.0, x64)
  • CompilerTSServer - node (v16.17.1, x64)
  • CompilerTSServer - node (v14.21.3, x64)
  • xstateTSServer - node (v18.10.0, x64)
  • xstateTSServer - node (v16.17.1, x64)
  • xstateTSServer - node (v14.21.3, x64)
Benchmark Name Iterations
Current 54634 6
Baseline main 6

Startup

Comparison Report - main..54634
Metric main 54634 Delta Best Worst p-value
tsc-startup - node (v16.17.1, x64)
Execution time 143.72ms (± 0.39%) 142.81ms (± 0.21%) -0.90ms (- 0.63%) 141.86ms 146.12ms p=0.000 n=600
tsserver-startup - node (v16.17.1, x64)
Execution time 225.73ms (± 0.51%) 223.39ms (± 0.44%) -2.34ms (- 1.04%) 220.88ms 230.71ms p=0.000 n=600
tsserverlibrary-startup - node (v16.17.1, x64)
Execution time 226.13ms (± 0.40%) 227.39ms (± 0.24%) +1.26ms (+ 0.56%) 223.20ms 232.36ms p=0.000 n=600
typescript-startup - node (v16.17.1, x64)
Execution time 207.95ms (± 0.41%) 207.13ms (± 0.41%) -0.82ms (- 0.39%) 204.54ms 215.71ms p=0.000 n=600
System
Machine Namets-ci-ubuntu
Platformlinux 5.4.0-148-generic
Architecturex64
Available Memory16 GB
Available Memory15 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v16.17.1, x64)
Scenarios
  • tsc-startup - node (v16.17.1, x64)
  • tsserver-startup - node (v16.17.1, x64)
  • tsserverlibrary-startup - node (v16.17.1, x64)
  • typescript-startup - node (v16.17.1, x64)
Benchmark Name Iterations
Current 54634 6
Baseline main 6

Developer Information:

Download Benchmark

@sandersn sandersn merged commit ed5008d into microsoft:main Jun 29, 2023
@Jack-Works Jack-Works deleted the improve-error-for-unclosed-import-export branch June 30, 2023 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sandersn sandersn sandersn approved these changes

@gabritto gabritto Awaiting requested review from gabritto

Assignees

@sandersn sandersn

Labels
For Uncommitted Bug PR for untriaged, rejected, closed or missing bug
Projects
PR Backlog
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Jack-Works @typescript-bot @sandersn