Skip to content

Incremental testing for program structure and resolutions and fixes #55814

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Sep 22, 2023

Conversation

sheetalkamat
Copy link
Member

@sheetalkamat sheetalkamat commented Sep 21, 2023

Retake of #54785

With this change in tsserver, tscWatch scenarios, we verify that incremental program structure is same as if it was constructed on initial pass.
This revealed few issues when running tests locally and on top tsserver200 that were easy to fix as i went along and one that i am still looking into.

  • ee9367a Fixes issues with symlink ref management which was revealed by f883100 where couple of tests in tsserver/symlinks failing because we were watching extra symlinks after program updates where we shouldn't have been
  • 6957dbf Fixes issue with ref counting when resolution of a file is done twice because of change in reference depth level
  • bdc8aa7 Fixes issue when inferred project removes files and resolutions from cache after program creation is complete but didnt earlier remove corresponding watchers
  • 3eac143 Fixes issue with file casing because auto import includes files with different casing
  • The other issue found by this was ddaf1c7 which is mitigated in tsserver with Source files not affected by all module resolution options #55790 and still pending for tsbuild scenario where we share module resolution cache and for future work with sharing resolutions across tsserver projects.

After merging this we should investigate having bot run tsserver100 /tsserver200 with incremental verification from nodeServer which is essentially 7fc6bc6

@typescript-bot typescript-bot added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Sep 21, 2023
@sheetalkamat sheetalkamat changed the title Incremental testing [WIP] Incremental testing for program structure and resolutions Sep 21, 2023
@sheetalkamat sheetalkamat changed the title [WIP] Incremental testing for program structure and resolutions Incremental testing for program structure and resolutions and fixes Sep 21, 2023
@sheetalkamat sheetalkamat marked this pull request as ready for review September 21, 2023 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants