Add file content as a parameter for the tsserver open command

[zhengbli]

Fix #5530.

[sandersn]

couldn't this be fileContent || this.host.readFile(filename) ?

[zhengbli]

@mhegazy @sandersn any other comments?

[mhegazy]

please add comment on how this is expected to work. and when the user should send it.

[mhegazy]

please add tests.

[mhegazy]

looks good. please add the comment and a test to ensure we do not break this in the future.

[sandersn]

Yes, looks good to me.

[dbaeumer]

@zhengbli: thanks for looking into this!
@mhegazy: to which branches will this be delivered. Any change to get this on 1.6.x which is still the version we are sitting on?

[mhegazy]

the best we can do is put it in 1.7. it is definitely going to be in 1.8.

[mhegazy]

is this blocking?

[zhengbli]

@mhegazy it might be blocking if it is used often with large files frequently I suppose, however the command is not supposed to be called very often (as suggested only in situations like when the server crashes)

[mhegazy]

👍

[mhegazy]

we can merge/cherry pick this into 1.7 as needed.

[mhegazy]

@dbaeumer would 1.7 work for you?

[dbaeumer]

@mhegazy we are still shipping 1.6.2. We did our testing last week and don't want to change the tsserver now. In addition the default TS npm package still seems to be 1.6.2.
With the help of Alex we put a work around into our system which makes the behavior Andres as seen go away. But it doesn't solve the general problem. So given the fact that 1.7 will come out soon it is ok to only have it in 1.7.

[billti]

👍