Skip to content

Update dprint and plugins #56163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Oct 28, 2023
Merged

Conversation

jakebailey
Copy link
Member

@jakebailey jakebailey commented Oct 20, 2023

The latest JSON plugin supports trailing commas and also special cases .vscode and files named tsconfig.json. I am not sure how I feel about the special casing, so maybe we should disable it; we have other tsconfig files that aren't found by the heuristic.

Now updated to just not allow trailing commas. VS Code complains about them and provides no mechanism to not complain about them.

@typescript-bot typescript-bot added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Oct 20, 2023
@jakebailey jakebailey changed the title Update dprint plugins Update dprint and plugins Oct 27, 2023
@jakebailey jakebailey marked this pull request as ready for review October 27, 2023 22:41
@jakebailey jakebailey merged commit 514f7e6 into microsoft:main Oct 28, 2023
@jakebailey jakebailey deleted the update-dprint-3 branch October 28, 2023 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants