Distribute mapped types over array/tuple intersections #57801

ahejlsberg · 2024-03-16T00:07:04Z

Fixes #57744 as described here.

ahejlsberg · 2024-03-16T00:07:59Z

@typescript-bot test top200
@typescript-bot user test this
@typescript-bot run dt
@typescript-bot perf test this faster

typescript-bot · 2024-03-16T00:08:03Z

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`test top200`	✅ Started	✅ Results
`user test this`	✅ Started	✅ Results
`run dt`	✅ Started	✅ Results
`perf test this faster`	✅ Started	👀 Results

typescript-bot · 2024-03-16T00:28:45Z

Hey @ahejlsberg, the results of running the DT tests are ready.
Everything looks the same!
You can check the log here.

typescript-bot · 2024-03-16T00:30:28Z

@ahejlsberg Here are the results of running the user test suite comparing main and refs/pull/57801/merge:

There were infrastructure failures potentially unrelated to your change:

1 instance of "Unknown failure"

Otherwise...

Everything looks good!

typescript-bot · 2024-03-16T00:59:10Z

@ahejlsberg
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Angular - node (v18.15.0, x64)}
_{Memory used}	_{295,730k (± 0.01%)}	_{295,709k (± 0.01%)}	_~	_295,644k	_295,730k	_{p=0.378 n=6}
_{Parse Time}	_{2.66s (± 0.28%)}	_{2.66s (± 0.24%)}	_~	_2.65s	_2.67s	_{p=0.718 n=6}
_{Bind Time}	_{0.83s (± 0.49%)}	_{0.83s (± 0.62%)}	_~	_0.82s	_0.83s	_{p=0.595 n=6}
_{Check Time}	_{8.19s (± 0.14%)}	_{8.21s (± 0.47%)}	_~	_8.16s	_8.27s	_{p=0.569 n=6}
_{Emit Time}	_{7.16s (± 0.68%)}	_{7.14s (± 0.14%)}	_~	_7.13s	_7.16s	_{p=0.616 n=6}
_{Total Time}	_{18.84s (± 0.26%)}	_{18.84s (± 0.16%)}	_~	_18.81s	_18.89s	_{p=1.000 n=6}
_{Compiler-Unions - node (v18.15.0, x64)}
_{Memory used}	_{191,937k (± 0.06%)}	_{193,209k (± 0.90%)}	_{+1,273k (+ 0.66%)}	_191,939k	_195,513k	_{p=0.020 n=6}
_{Parse Time}	_{1.35s (± 0.47%)}	_{1.36s (± 1.20%)}	_~	_1.33s	_1.38s	_{p=0.236 n=6}
_{Bind Time}	_{0.72s (± 0.00%)}	_{0.72s (± 0.00%)}	_~	_0.72s	_0.72s	_{p=1.000 n=6}
_{Check Time}	_{9.47s (± 0.71%)}	_{9.48s (± 0.72%)}	_~	_9.39s	_9.59s	_{p=0.423 n=6}
_{Emit Time}	_{2.66s (± 0.31%)}	_{2.65s (± 0.57%)}	_~	_2.63s	_2.67s	_{p=1.000 n=6}
_{Total Time}	_{14.20s (± 0.46%)}	_{14.22s (± 0.39%)}	_~	_14.12s	_14.29s	_{p=0.297 n=6}
_{Monaco - node (v18.15.0, x64)}
_{Memory used}	_{347,358k (± 0.00%)}	_{347,366k (± 0.01%)}	_~	_347,344k	_347,399k	_{p=0.630 n=6}
_{Parse Time}	_{2.47s (± 0.49%)}	_{2.48s (± 0.59%)}	_~	_2.46s	_2.50s	_{p=0.325 n=6}
_{Bind Time}	_{0.92s (± 0.56%)}	_{0.92s (± 0.59%)}	_~	_0.92s	_0.93s	_{p=0.640 n=6}
_{Check Time}	_{7.01s (± 0.35%)}	_{7.02s (± 0.21%)}	_~	_7.00s	_7.03s	_{p=0.869 n=6}
_{Emit Time}	_{4.07s (± 0.80%)}	_{4.06s (± 0.29%)}	_~	_4.04s	_4.07s	_{p=0.935 n=6}
_{Total Time}	_{14.48s (± 0.33%)}	_{14.48s (± 0.21%)}	_~	_14.45s	_14.53s	_{p=0.872 n=6}
_{TFS - node (v18.15.0, x64)}
_{Memory used}	_{302,721k (± 0.00%)}	_{302,728k (± 0.01%)}	_~	_302,711k	_302,756k	_{p=0.520 n=6}
_{Parse Time}	_{2.02s (± 0.60%)}	_{2.01s (± 1.11%)}	_~	_1.97s	_2.03s	_{p=0.618 n=6}
_{Bind Time}	_{1.00s (± 0.41%)}	_{1.00s (± 1.17%)}	_~	_0.99s	_1.02s	_{p=0.858 n=6}
_{Check Time}	_{6.31s (± 0.43%)}	_{6.29s (± 0.34%)}	_~	_6.25s	_6.31s	_{p=0.224 n=6}
_{Emit Time}	_{3.61s (± 0.43%)}	_{3.61s (± 0.73%)}	_~	_3.58s	_3.64s	_{p=0.682 n=6}
_{Total Time}	_{12.94s (± 0.25%)}	_{12.91s (± 0.28%)}	_~	_12.87s	_12.96s	_{p=0.376 n=6}
_{material-ui - node (v18.15.0, x64)}
_{Memory used}	_{511,368k (± 0.00%)}	_{511,371k (± 0.00%)}	_~	_511,347k	_511,399k	_{p=0.689 n=6}
_{Parse Time}	_{2.65s (± 0.74%)}	_{2.66s (± 0.31%)}	_~	_2.64s	_2.66s	_{p=0.557 n=6}
_{Bind Time}	_{0.98s (± 0.52%)}	_{0.99s (± 0.41%)}	_~	_0.98s	_0.99s	_{p=0.112 n=6}
_{Check Time}	_{17.37s (± 0.69%)}	_{17.34s (± 0.63%)}	_~	_17.18s	_17.50s	_{p=0.936 n=6}
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_~	_0.00s	_0.00s	_{p=1.000 n=6}
_{Total Time}	_{21.00s (± 0.58%)}	_{20.98s (± 0.46%)}	_~	_20.84s	_21.12s	_{p=0.872 n=6}
_{mui-docs - node (v18.15.0, x64)}
_{Memory used}	_{1,798,046k (± 0.00%)}	_{1,798,070k (± 0.00%)}	_~	_1,798,029k	_1,798,122k	_{p=0.229 n=6}
_{Parse Time}	_{6.61s (± 0.63%)}	_{6.63s (± 0.71%)}	_~	_6.57s	_6.71s	_{p=0.195 n=6}
_{Bind Time}	_{2.40s (± 0.57%)}	_{2.39s (± 0.46%)}	_~	_2.37s	_2.40s	_{p=0.554 n=6}
_{Check Time}	_{59.06s (± 0.42%)}	_{59.21s (± 0.33%)}	_~	_59.00s	_59.55s	_{p=0.378 n=6}
_{Emit Time}	_{0.16s (± 3.16%)}	_{0.16s (± 0.00%)}	_~	_0.16s	_0.16s	_{p=0.174 n=6}
_{Total Time}	_{68.23s (± 0.40%)}	_{68.39s (± 0.28%)}	_~	_68.22s	_68.74s	_{p=0.149 n=6}
_{self-build-src - node (v18.15.0, x64)}
_{Memory used}	_{2,397,244k (± 0.03%)}	_{2,397,215k (± 0.03%)}	_~	_2,396,503k	_2,398,260k	_{p=1.000 n=6}
_{Parse Time}	_{5.01s (± 1.05%)}	_{5.01s (± 0.95%)}	_~	_4.95s	_5.06s	_{p=0.574 n=6}
_{Bind Time}	_{1.91s (± 1.03%)}	_{1.91s (± 1.16%)}	_~	_1.89s	_1.95s	_{p=0.935 n=6}
_{Check Time}	_{33.48s (± 0.32%)}	_{33.52s (± 0.23%)}	_~	_33.44s	_33.65s	_{p=0.574 n=6}
_{Emit Time}	_{2.72s (± 1.39%)}	_{2.72s (± 1.54%)}	_~	_2.67s	_2.78s	_{p=0.936 n=6}
_{Total Time}	_{43.14s (± 0.21%)}	_{43.19s (± 0.29%)}	_~	_43.03s	_43.37s	_{p=0.748 n=6}
_{self-compiler - node (v18.15.0, x64)}
_{Memory used}	_{415,515k (± 0.01%)}	_{415,464k (± 0.00%)}	_{-51k (- 0.01%)}	_415,447k	_415,487k	_{p=0.020 n=6}
_{Parse Time}	_{2.84s (± 0.66%)}	_{2.82s (± 0.92%)}	_~	_2.79s	_2.86s	_{p=0.167 n=6}
_{Bind Time}	_{1.06s (± 0.38%)}	_{1.07s (± 0.92%)}	_~	_1.06s	_1.08s	_{p=0.071 n=6}
_{Check Time}	_{15.30s (± 0.55%)}	_{15.30s (± 0.37%)}	_~	_15.25s	_15.39s	_{p=0.936 n=6}
_{Emit Time}	_{1.16s (± 0.65%)}	_{1.15s (± 0.65%)}	_~	_1.14s	_1.16s	_{p=0.195 n=6}
_{Total Time}	_{20.36s (± 0.33%)}	_{20.34s (± 0.38%)}	_~	_20.26s	_20.44s	_{p=0.687 n=6}
_{vscode - node (v18.15.0, x64)}
_{Memory used}	_{2,880,619k (± 0.00%)}	_{2,880,620k (± 0.00%)}	_~	_2,880,572k	_2,880,663k	_{p=0.936 n=6}
_{Parse Time}	_{10.81s (± 0.26%)}	_{10.80s (± 0.27%)}	_~	_10.75s	_10.83s	_{p=1.000 n=6}
_{Bind Time}	_{3.45s (± 0.51%)}	_{3.46s (± 0.47%)}	_~	_3.45s	_3.49s	_{p=0.324 n=6}
_{Check Time}	_{61.24s (± 0.19%)}	_{61.21s (± 0.33%)}	_~	_61.02s	_61.59s	_{p=0.377 n=6}
_{Emit Time}	_{16.50s (± 1.55%)}	_{16.38s (± 0.57%)}	_~	_16.26s	_16.49s	_{p=0.521 n=6}
_{Total Time}	_{92.01s (± 0.40%)}	_{91.85s (± 0.21%)}	_~	_91.65s	_92.21s	_{p=0.378 n=6}
_{webpack - node (v18.15.0, x64)}
_{Memory used}	_{406,530k (± 0.02%)}	_{406,481k (± 0.02%)}	_~	_406,399k	_406,581k	_{p=0.230 n=6}
_{Parse Time}	_{3.19s (± 0.90%)}	_{3.20s (± 0.55%)}	_~	_3.17s	_3.22s	_{p=0.935 n=6}
_{Bind Time}	_{1.37s (± 0.85%)}	_{1.38s (± 0.59%)}	_~	_1.38s	_1.40s	_{p=0.056 n=6}
_{Check Time}	_{14.25s (± 0.16%)}	_{14.22s (± 0.40%)}	_~	_14.12s	_14.29s	_{p=0.197 n=6}
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_~	_0.00s	_0.00s	_{p=1.000 n=6}
_{Total Time}	_{18.82s (± 0.23%)}	_{18.80s (± 0.29%)}	_~	_18.69s	_18.84s	_{p=0.870 n=6}
_{xstate - node (v18.15.0, x64)}
_{Memory used}	_{513,261k (± 0.01%)}	_{513,243k (± 0.01%)}	_~	_513,156k	_513,344k	_{p=0.810 n=6}
_{Parse Time}	_{3.28s (± 0.39%)}	_{3.27s (± 0.30%)}	_~	_3.26s	_3.28s	_{p=0.214 n=6}
_{Bind Time}	_{1.54s (± 0.26%)}	_{1.54s (± 0.36%)}	_~	_1.53s	_1.54s	_{p=0.054 n=6}
_{Check Time}	_{2.85s (± 0.60%)}	_{2.85s (± 0.48%)}	_~	_2.83s	_2.87s	_{p=1.000 n=6}
_{Emit Time}	_{0.07s (± 7.03%)}	_{0.07s (± 5.69%)}	_~	_0.07s	_0.08s	_{p=0.595 n=6}
_{Total Time}	_{7.75s (± 0.25%)}	_{7.74s (± 0.28%)}	_~	_7.70s	_7.76s	_{p=0.279 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

Angular - node (v18.15.0, x64)
Compiler-Unions - node (v18.15.0, x64)
Monaco - node (v18.15.0, x64)
TFS - node (v18.15.0, x64)
material-ui - node (v18.15.0, x64)
mui-docs - node (v18.15.0, x64)
self-build-src - node (v18.15.0, x64)
self-compiler - node (v18.15.0, x64)
vscode - node (v18.15.0, x64)
webpack - node (v18.15.0, x64)
xstate - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

typescript-bot · 2024-03-16T01:09:46Z

@ahejlsberg Here are the results of running the top-repos suite comparing main and refs/pull/57801/merge:

Everything looks good!

RyanCavanaugh · 2024-03-18T16:56:04Z

@typescript-bot cherry-pick this to release-5.4

typescript-bot · 2024-03-18T16:56:06Z

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`cherry-pick this to release-5.4`	✅ Started	✅ Results

typescript-bot · 2024-03-18T16:58:28Z

Hey, @RyanCavanaugh! I've created #57832 for you.

…e-5.4 (#57832) Co-authored-by: Anders Hejlsberg <andersh@microsoft.com>

ahejlsberg added 2 commits March 15, 2024 16:26

Distribute mapped types over array/tuple intersections

5fb6593

Add tests

55f2fd0

typescript-bot assigned ahejlsberg Mar 16, 2024

typescript-bot added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Mar 16, 2024

ahejlsberg requested a review from RyanCavanaugh March 16, 2024 00:18

RyanCavanaugh approved these changes Mar 18, 2024

View reviewed changes

typescript-bot mentioned this pull request Mar 18, 2024

🤖 Pick PR #57801 (Distribute mapped types over array/...) into release-5.4 #57832

Merged

ahejlsberg merged commit 37fa47e into main Mar 18, 2024
26 checks passed

ahejlsberg deleted the fix57744 branch March 18, 2024 17:07

RyanCavanaugh pushed a commit that referenced this pull request Mar 18, 2024

🤖 Pick PR #57801 (Distribute mapped types over array/...) into releas…

b45a418

…e-5.4 (#57832) Co-authored-by: Anders Hejlsberg <andersh@microsoft.com>

DanielRosenwasser added this to the TypeScript 5.4.3 milestone Mar 19, 2024

This was referenced Sep 5, 2024

Error type on spreading array with additional props #59849

Open

Distribute mapped types over intersections with some array/tuple members #59864

Open

This was referenced Sep 27, 2024

Add numeric constraints to type parameters of mapped types with array/tuple intersections constraints #60084

Open

Add numeric constraints to type parameters of mapped types with narrowed down array constraints #55386

Draft

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Distribute mapped types over array/tuple intersections #57801

Distribute mapped types over array/tuple intersections #57801

ahejlsberg commented Mar 16, 2024

ahejlsberg commented Mar 16, 2024

typescript-bot commented Mar 16, 2024 •

edited

Loading

typescript-bot commented Mar 16, 2024

typescript-bot commented Mar 16, 2024

typescript-bot commented Mar 16, 2024

tsc

typescript-bot commented Mar 16, 2024

RyanCavanaugh commented Mar 18, 2024

typescript-bot commented Mar 18, 2024 •

edited

Loading

typescript-bot commented Mar 18, 2024

Distribute mapped types over array/tuple intersections #57801

Distribute mapped types over array/tuple intersections #57801

Conversation

ahejlsberg commented Mar 16, 2024

ahejlsberg commented Mar 16, 2024

typescript-bot commented Mar 16, 2024 • edited Loading

typescript-bot commented Mar 16, 2024

typescript-bot commented Mar 16, 2024

typescript-bot commented Mar 16, 2024

tsc

typescript-bot commented Mar 16, 2024

RyanCavanaugh commented Mar 18, 2024

typescript-bot commented Mar 18, 2024 • edited Loading

typescript-bot commented Mar 18, 2024

typescript-bot commented Mar 16, 2024 •

edited

Loading

typescript-bot commented Mar 18, 2024 •

edited

Loading