Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Region-based semantic diagnostics #57842

Merged
merged 83 commits into from
Jun 13, 2024
Merged

Region-based semantic diagnostics #57842

merged 83 commits into from
Jun 13, 2024

Commits on Feb 27, 2024

  1. WIP

    @gabritto
    gabritto committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    ce6ed79 View commit details
    Browse the repository at this point in the history

Commits on Mar 1, 2024

  1. add nodesToCheck param; compute it from ranges

    @gabritto
    gabritto committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    33ed16a View commit details
    Browse the repository at this point in the history

Commits on Mar 2, 2024

  1. more end-to-end changes

    @gabritto
    gabritto committed Mar 2, 2024
    Configuration menu
    Copy the full SHA
    cf54694 View commit details
    Browse the repository at this point in the history

  2. lint fixes, api baseline changes

    @gabritto
    gabritto committed Mar 2, 2024
    Configuration menu
    Copy the full SHA
    9647997 View commit details
    Browse the repository at this point in the history

Commits on Mar 4, 2024

  1. small fix, update baseline

    @gabritto
    gabritto committed Mar 4, 2024
    Configuration menu
    Copy the full SHA
    9cd0edc View commit details
    Browse the repository at this point in the history

  2. get project right before checking for errors

    @gabritto
    gabritto committed Mar 4, 2024
    Configuration menu
    Copy the full SHA
    eeb91c5 View commit details
    Browse the repository at this point in the history

Commits on Mar 5, 2024

  1. fix type error and tests

    @gabritto
    gabritto committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    38861fb View commit details
    Browse the repository at this point in the history

Commits on Mar 7, 2024

  1. WIP: return spans in region diagnostics event

    @gabritto
    gabritto committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    b46560a View commit details
    Browse the repository at this point in the history

Commits on Mar 8, 2024

  1. add perf for testing

    @gabritto
    gabritto committed Mar 8, 2024
    Configuration menu
    Copy the full SHA
    22637a4 View commit details
    Browse the repository at this point in the history

Commits on Mar 12, 2024

  1. include less nodes in nodes to check

    @gabritto
    gabritto committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    6e03d01 View commit details
    Browse the repository at this point in the history

Commits on Mar 15, 2024

  1. add unit test, more fixes

    @gabritto
    gabritto committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    7af55c2 View commit details
    Browse the repository at this point in the history

  2. fix things and add unit test

    @gabritto
    gabritto committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    1d2b665 View commit details
    Browse the repository at this point in the history

Commits on Mar 19, 2024

  1. Merge branch 'main' into gabritto/regiondiag

    @gabritto
    gabritto committed Mar 19, 2024
    Configuration menu
    Copy the full SHA
    e0cf3c6 View commit details
    Browse the repository at this point in the history

  2. refactors

    @gabritto
    gabritto committed Mar 19, 2024
    Configuration menu
    Copy the full SHA
    c25a879 View commit details
    Browse the repository at this point in the history

  3. refactor type

    @gabritto
    gabritto committed Mar 19, 2024
    Configuration menu
    Copy the full SHA
    0a55946 View commit details
    Browse the repository at this point in the history

Commits on Mar 22, 2024

  1. update protocol comment

    @gabritto
    gabritto committed Mar 22, 2024
    Configuration menu
    Copy the full SHA
    1b4e458 View commit details
    Browse the repository at this point in the history

Commits on Mar 26, 2024

  1. restore checker arrays between region and full check

    @gabritto
    gabritto committed Mar 26, 2024
    Configuration menu
    Copy the full SHA
    a936ff0 View commit details
    Browse the repository at this point in the history

  2. fmt

    @gabritto
    gabritto committed Mar 26, 2024
    Configuration menu
    Copy the full SHA
    13543e1 View commit details
    Browse the repository at this point in the history

Commits on Mar 28, 2024

  1. only include unused directive errors for checked range

    @gabritto
    gabritto committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    7b53e4f View commit details
    Browse the repository at this point in the history

  2. properly compute checked span

    @gabritto
    gabritto committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    69aacf4 View commit details
    Browse the repository at this point in the history

  3. update comments

    @gabritto
    gabritto committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    63c543d View commit details
    Browse the repository at this point in the history

  4. pass around compressed spans so that we do unused directive check mor… 

    …e efficiently
    @gabritto
    gabritto committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    b51921d View commit details
    Browse the repository at this point in the history

Commits on Mar 31, 2024

  1. Revert "pass around compressed spans so that we do unused directive c… 

    …heck more efficiently"

This reverts commit b51921d.
    @gabritto
    gabritto committed Mar 31, 2024
    Configuration menu
    Copy the full SHA
    aac18b1 View commit details
    Browse the repository at this point in the history

  2. don't error on unused directives

    @gabritto
    gabritto committed Mar 31, 2024
    Configuration menu
    Copy the full SHA
    9a1c344 View commit details
    Browse the repository at this point in the history

Commits on Apr 1, 2024

  1. tweak node selection

    @gabritto
    gabritto committed Apr 1, 2024
    Configuration menu
    Copy the full SHA
    64d0699 View commit details
    Browse the repository at this point in the history

  2. add region semantic test infra; inconsistent diagnostic test

    @gabritto
    gabritto committed Apr 1, 2024
    Configuration menu
    Copy the full SHA
    d445be5 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into gabritto/regiondiag

    @gabritto
    gabritto committed Apr 1, 2024
    Configuration menu
    Copy the full SHA
    43712cd View commit details
    Browse the repository at this point in the history

  4. update test baseline

    @gabritto
    gabritto committed Apr 1, 2024
    Configuration menu
    Copy the full SHA
    ab5a25c View commit details
    Browse the repository at this point in the history

Commits on Apr 2, 2024

  1. add inconsistent 2307 test

    @gabritto
    gabritto committed Apr 2, 2024
    Configuration menu
    Copy the full SHA
    148f9ad View commit details
    Browse the repository at this point in the history

  2. 2354 inconsistent position test

    @gabritto
    gabritto committed Apr 2, 2024
    Configuration menu
    Copy the full SHA
    58a4f5f View commit details
    Browse the repository at this point in the history

  3. test for extra 2344

    @gabritto
    gabritto committed Apr 2, 2024
    Configuration menu
    Copy the full SHA
    1ac37e8 View commit details
    Browse the repository at this point in the history

Commits on Apr 3, 2024

  1. add test for spans checked by region check

    @gabritto
    gabritto committed Apr 3, 2024
    Configuration menu
    Copy the full SHA
    9276bd3 View commit details
    Browse the repository at this point in the history

  2. add test for extra 2416

    @gabritto
    gabritto committed Apr 3, 2024
    Configuration menu
    Copy the full SHA
    caf6fc4 View commit details
    Browse the repository at this point in the history

  3. add test for 2740 extra

    @gabritto
    gabritto committed Apr 3, 2024
    Configuration menu
    Copy the full SHA
    e102e49 View commit details
    Browse the repository at this point in the history

Commits on Apr 4, 2024

  1. add test for react error

    @gabritto
    gabritto committed Apr 4, 2024
    Configuration menu
    Copy the full SHA
    32ec3b1 View commit details
    Browse the repository at this point in the history

Commits on Apr 10, 2024

  1. avoid re-checking nodes

    @gabritto
    gabritto committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    52b9e33 View commit details
    Browse the repository at this point in the history

  2. format

    @gabritto
    gabritto committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    80698d3 View commit details
    Browse the repository at this point in the history

Commits on Apr 25, 2024

  1. Merge branch 'main' into gabritto/regiondiag

    @gabritto
    gabritto committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    467b1a2 View commit details
    Browse the repository at this point in the history

Commits on Apr 26, 2024

  1. remove console.log

    @gabritto
    gabritto committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    ae6a7ec View commit details
    Browse the repository at this point in the history

Commits on Apr 29, 2024

  1. Merge branch 'main' into gabritto/regiondiag

    @gabritto
    gabritto committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    0a47d91 View commit details
    Browse the repository at this point in the history

  2. update baseline

    @gabritto
    gabritto committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    46813c7 View commit details
    Browse the repository at this point in the history

Commits on May 3, 2024

  1. remove failing tests

    @gabritto
    gabritto committed May 3, 2024
    Configuration menu
    Copy the full SHA
    dee2885 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into gabritto/regiondiag

    @gabritto
    gabritto committed May 3, 2024
    Configuration menu
    Copy the full SHA
    898325f View commit details
    Browse the repository at this point in the history

  3. fmt

    @gabritto
    gabritto committed May 3, 2024
    Configuration menu
    Copy the full SHA
    13a7ab7 View commit details
    Browse the repository at this point in the history

  4. fix default for var

    @gabritto
    gabritto committed May 3, 2024
    Configuration menu
    Copy the full SHA
    7e8d763 View commit details
    Browse the repository at this point in the history

Commits on May 21, 2024

  1. CR: get rid of unnecessary boolean flag for partial check

    @gabritto
    gabritto committed May 21, 2024
    Configuration menu
    Copy the full SHA
    b51af9c View commit details
    Browse the repository at this point in the history

  2. CR: get rid of option to exclude duration from diagnostics event, san… 

    …itize logs, update unit tests
    @gabritto
    gabritto committed May 21, 2024
    Configuration menu
    Copy the full SHA
    a3cdc74 View commit details
    Browse the repository at this point in the history

  3. CR: make shouldDoRegionCheck internal and override it in TestSession

    @gabritto
    gabritto committed May 21, 2024
    Configuration menu
    Copy the full SHA
    4d3f068 View commit details
    Browse the repository at this point in the history

  4. CR: clean up session's semantic check perf data when file is closed

    @gabritto
    gabritto committed May 21, 2024
    Configuration menu
    Copy the full SHA
    11b7966 View commit details
    Browse the repository at this point in the history

  5. CR: make unit test helper verifyGetErrRequest support region-based … 

    …diagnostics
    @gabritto
    gabritto committed May 21, 2024
    Configuration menu
    Copy the full SHA
    f02cef4 View commit details
    Browse the repository at this point in the history

  6. CR: mark region diagnostics methods as internal

    @gabritto
    gabritto committed May 21, 2024
    Configuration menu
    Copy the full SHA
    e62ec2e View commit details
    Browse the repository at this point in the history

Commits on May 22, 2024

  1. CR: add test for multiple files; fix testing helper to support region… 

    … diagnostics
    @gabritto
    gabritto committed May 22, 2024
    Configuration menu
    Copy the full SHA
    90ef005 View commit details
    Browse the repository at this point in the history

  2. fix overload lint error

    @gabritto
    gabritto committed May 22, 2024
    Configuration menu
    Copy the full SHA
    eaa9b53 View commit details
    Browse the repository at this point in the history

  3. CR: add unit tests with suggestions

    @gabritto
    gabritto committed May 22, 2024
    Configuration menu
    Copy the full SHA
    3e49b6b View commit details
    Browse the repository at this point in the history

  4. change order of checking for files with specified regions

    @gabritto
    gabritto committed May 22, 2024
    Configuration menu
    Copy the full SHA
    0ef9bb8 View commit details
    Browse the repository at this point in the history

  5. fix log sanitizing regex

    @gabritto
    gabritto committed May 22, 2024
    Configuration menu
    Copy the full SHA
    8e160cf View commit details
    Browse the repository at this point in the history

  6. Merge branch 'main' into gabritto/regiondiag

    @gabritto
    gabritto committed May 22, 2024
    Configuration menu
    Copy the full SHA
    30a0aad View commit details
    Browse the repository at this point in the history

Commits on May 23, 2024

  1. update unit tests logs with duration

    @gabritto
    gabritto committed May 23, 2024
    Configuration menu
    Copy the full SHA
    ece3c41 View commit details
    Browse the repository at this point in the history

  2. remove unused baseline

    @gabritto
    gabritto committed May 23, 2024
    Configuration menu
    Copy the full SHA
    0251194 View commit details
    Browse the repository at this point in the history

  3. optimization: don't do region node selection if we will skip checking… 

    … the file
    @gabritto
    gabritto committed May 23, 2024
    Configuration menu
    Copy the full SHA
    7076d14 View commit details
    Browse the repository at this point in the history

  4. don't record semantic diagnostic time if could have done region check

    @gabritto
    gabritto committed May 23, 2024
    Configuration menu
    Copy the full SHA
    48f87a8 View commit details
    Browse the repository at this point in the history

  5. improve optimization

    @gabritto
    gabritto committed May 23, 2024
    Configuration menu
    Copy the full SHA
    81dc370 View commit details
    Browse the repository at this point in the history

Commits on May 24, 2024

  1. add line count and use it for deciding on region check

    @gabritto
    gabritto committed May 24, 2024
    Configuration menu
    Copy the full SHA
    5e6ce98 View commit details
    Browse the repository at this point in the history

Commits on May 30, 2024

  1. TEMPORARY FOR TESTING VSCODE

    @gabritto
    gabritto committed May 30, 2024
    Configuration menu
    Copy the full SHA
    3254be9 View commit details
    Browse the repository at this point in the history

  2. get rid of performance checking in heuristic for now

    @gabritto
    gabritto committed May 30, 2024
    Configuration menu
    Copy the full SHA
    ef6e4d5 View commit details
    Browse the repository at this point in the history

Commits on Jun 7, 2024

  1. CR: mark internal

    @gabritto
    gabritto committed Jun 7, 2024
    Configuration menu
    Copy the full SHA
    c07b226 View commit details
    Browse the repository at this point in the history

  2. CR: refactor session.ts

    @gabritto
    gabritto committed Jun 7, 2024
    Configuration menu
    Copy the full SHA
    1f262cd View commit details
    Browse the repository at this point in the history

  3. always do semantic check in next immediate step

    @gabritto
    gabritto committed Jun 7, 2024
    Configuration menu
    Copy the full SHA
    34bcbb2 View commit details
    Browse the repository at this point in the history

  4. fix rebase problem

    @gabritto
    gabritto committed Jun 7, 2024
    Configuration menu
    Copy the full SHA
    52eadaa View commit details
    Browse the repository at this point in the history

Commits on Jun 10, 2024

  1. fix baselines

    @gabritto
    gabritto committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    12979b7 View commit details
    Browse the repository at this point in the history

  2. check files in the order of the request

    @gabritto
    gabritto committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    830c118 View commit details
    Browse the repository at this point in the history

Commits on Jun 11, 2024

  1. refactor unit test

    @gabritto
    gabritto committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    d3a8f41 View commit details
    Browse the repository at this point in the history

  2. add option for test session to always enable region checking

    @gabritto
    gabritto committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    1752f8f View commit details
    Browse the repository at this point in the history

  3. add test for skipped region diagnostics

    @gabritto
    gabritto committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    9320a45 View commit details
    Browse the repository at this point in the history

  4. format

    @gabritto
    gabritto committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    68831d1 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'main' into gabritto/regiondiag

    @gabritto
    gabritto committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    2f2e02f View commit details
    Browse the repository at this point in the history

  6. add test for file with ts-nocheck

    @gabritto
    gabritto committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    eb168b6 View commit details
    Browse the repository at this point in the history

Commits on Jun 12, 2024

  1. Merge branch 'main' into gabritto/regiondiag

    @gabritto
    gabritto committed Jun 12, 2024
    Configuration menu
    Copy the full SHA
    c571ae0 View commit details
    Browse the repository at this point in the history

  2. add comments and minor refactor

    @gabritto
    gabritto committed Jun 12, 2024
    Configuration menu
    Copy the full SHA
    7c512ac View commit details
    Browse the repository at this point in the history

Commits on Jun 13, 2024

  1. Merge branch 'main' into gabritto/regiondiag

    @gabritto
    gabritto committed Jun 13, 2024
    Configuration menu
    Copy the full SHA
    9f2727b View commit details
    Browse the repository at this point in the history

  2. refactor

    @gabritto
    gabritto committed Jun 13, 2024
    Configuration menu
    Copy the full SHA
    ec6772c View commit details
    Browse the repository at this point in the history

  3. refactor updateErrorCheck to delay work again

    @gabritto
    gabritto committed Jun 13, 2024
    Configuration menu
    Copy the full SHA
    f1d87dc View commit details
    Browse the repository at this point in the history

  4. mark region threshold as internal

    @gabritto
    gabritto committed Jun 13, 2024
    Configuration menu
    Copy the full SHA
    5ed581a View commit details
    Browse the repository at this point in the history