Code

Region-based semantic diagnostics#57842

Code

Merged

gabritto merged 83 commits intomainmicrosoft/TypeScript:mainfrom gabritto/regiondiagmicrosoft/TypeScript:gabritto/regiondiagCopy head branch name to clipboardJun 13, 2024

+4,872-927

Commits

Commits on Feb 27, 2024

• WIP

  gabritto

  committed
  ce6ed79

  Copy full SHA for ce6ed79

Commits on Mar 1, 2024

• add nodesToCheck param; compute it from ranges

  gabritto

  committed
  33ed16a

  Copy full SHA for 33ed16a

Commits on Mar 2, 2024

• more end-to-end changes

  gabritto

  committed
  cf54694

  Copy full SHA for cf54694

• lint fixes, api baseline changes

  gabritto

  committed
  9647997

  Copy full SHA for 9647997

Commits on Mar 4, 2024

• small fix, update baseline

  gabritto

  committed
  9cd0edc

  Copy full SHA for 9cd0edc

• get project right before checking for errors

  gabritto

  committed
  eeb91c5

  Copy full SHA for eeb91c5

Commits on Mar 5, 2024

• fix type error and tests

  gabritto

  committed
  38861fb

  Copy full SHA for 38861fb

Commits on Mar 7, 2024

• WIP: return spans in region diagnostics event

  gabritto

  committed
  b46560a

  Copy full SHA for b46560a

Commits on Mar 8, 2024

• add perf for testing

  gabritto

  committed
  22637a4

  Copy full SHA for 22637a4

Commits on Mar 12, 2024

• include less nodes in nodes to check

  gabritto

  committed
  6e03d01

  Copy full SHA for 6e03d01

Commits on Mar 15, 2024

• add unit test, more fixes

  gabritto

  committed
  7af55c2

  Copy full SHA for 7af55c2

• fix things and add unit test

  gabritto

  committed
  1d2b665

  Copy full SHA for 1d2b665

Commits on Mar 19, 2024

• Merge branch 'main' into gabritto/regiondiag

  gabritto

  committed
  e0cf3c6

  Copy full SHA for e0cf3c6

• refactors

  gabritto

  committed
  c25a879

  Copy full SHA for c25a879

• refactor type

  gabritto

  committed
  0a55946

  Copy full SHA for 0a55946

Commits on Mar 22, 2024

• update protocol comment

  gabritto

  committed
  1b4e458

  Copy full SHA for 1b4e458

Commits on Mar 26, 2024

• restore checker arrays between region and full check

  gabritto

  committed
  a936ff0

  Copy full SHA for a936ff0

• fmt

  gabritto

  committed
  13543e1

  Copy full SHA for 13543e1

Commits on Mar 28, 2024

• only include unused directive errors for checked range

  gabritto

  committed
  7b53e4f

  Copy full SHA for 7b53e4f

• properly compute checked span

  gabritto

  committed
  69aacf4

  Copy full SHA for 69aacf4

• update comments

  gabritto

  committed
  63c543d

  Copy full SHA for 63c543d

• pass around compressed spans so that we do unused directive check more efficiently

  gabritto

  committed
  b51921d

  Copy full SHA for b51921d

Commits on Mar 31, 2024

• Revert "pass around compressed spans so that we do unused directive check more efficiently"

  Show description for aac18b1
  gabritto

  committed
  aac18b1

  Copy full SHA for aac18b1

• don't error on unused directives

  gabritto

  committed
  9a1c344

  Copy full SHA for 9a1c344

Commits on Apr 1, 2024

• tweak node selection

  gabritto

  committed
  64d0699

  Copy full SHA for 64d0699

• add region semantic test infra; inconsistent diagnostic test

  gabritto

  committed
  d445be5

  Copy full SHA for d445be5

• Merge branch 'main' into gabritto/regiondiag

  gabritto

  committed
  43712cd

  Copy full SHA for 43712cd

• update test baseline

  gabritto

  committed
  ab5a25c

  Copy full SHA for ab5a25c

Commits on Apr 2, 2024

• add inconsistent 2307 test

  gabritto

  committed
  148f9ad

  Copy full SHA for 148f9ad

• 2354 inconsistent position test

  gabritto

  committed
  58a4f5f

  Copy full SHA for 58a4f5f

• test for extra 2344

  gabritto

  committed
  1ac37e8

  Copy full SHA for 1ac37e8

Commits on Apr 3, 2024

• add test for spans checked by region check

  gabritto

  committed
  9276bd3

  Copy full SHA for 9276bd3

• add test for extra 2416

  gabritto

  committed
  caf6fc4

  Copy full SHA for caf6fc4

• add test for 2740 extra

  gabritto

  committed
  e102e49

  Copy full SHA for e102e49

Commits on Apr 4, 2024

• add test for react error

  gabritto

  committed
  32ec3b1

  Copy full SHA for 32ec3b1

Commits on Apr 10, 2024

• avoid re-checking nodes

  gabritto

  committed
  52b9e33

  Copy full SHA for 52b9e33

• format

  gabritto

  committed
  80698d3

  Copy full SHA for 80698d3

Commits on Apr 25, 2024

• Merge branch 'main' into gabritto/regiondiag

  gabritto

  committed
  467b1a2

  Copy full SHA for 467b1a2

Commits on Apr 26, 2024

• remove console.log

  gabritto

  committed
  ae6a7ec

  Copy full SHA for ae6a7ec

Commits on Apr 29, 2024

• Merge branch 'main' into gabritto/regiondiag

  gabritto

  committed
  0a47d91

  Copy full SHA for 0a47d91

• update baseline

  gabritto

  committed
  46813c7

  Copy full SHA for 46813c7

Commits on May 3, 2024

• remove failing tests

  gabritto

  committed
  dee2885

  Copy full SHA for dee2885

• Merge branch 'main' into gabritto/regiondiag

  gabritto

  committed
  898325f

  Copy full SHA for 898325f

• fmt

  gabritto

  committed
  13a7ab7

  Copy full SHA for 13a7ab7

• fix default for var

  gabritto

  committed
  7e8d763

  Copy full SHA for 7e8d763

Commits on May 21, 2024

• CR: get rid of unnecessary boolean flag for partial check

  gabritto

  committed
  b51af9c

  Copy full SHA for b51af9c

• CR: get rid of option to exclude duration from diagnostics event, sanitize logs, update unit tests

  gabritto

  committed
  a3cdc74

  Copy full SHA for a3cdc74

• CR: make shouldDoRegionCheck internal and override it in TestSession

  gabritto

  committed
  4d3f068

  Copy full SHA for 4d3f068

• CR: clean up session's semantic check perf data when file is closed

  gabritto

  committed
  11b7966

  Copy full SHA for 11b7966

• CR: make unit test helper verifyGetErrRequest support region-based diagnostics

  gabritto

  committed
  f02cef4

  Copy full SHA for f02cef4

• CR: mark region diagnostics methods as internal

  gabritto

  committed
  e62ec2e

  Copy full SHA for e62ec2e

Commits on May 22, 2024

• CR: add test for multiple files; fix testing helper to support region diagnostics

  gabritto

  committed
  90ef005

  Copy full SHA for 90ef005

• fix overload lint error

  gabritto

  committed
  eaa9b53

  Copy full SHA for eaa9b53

• CR: add unit tests with suggestions

  gabritto

  committed
  3e49b6b

  Copy full SHA for 3e49b6b

• change order of checking for files with specified regions

  gabritto

  committed
  0ef9bb8

  Copy full SHA for 0ef9bb8

• fix log sanitizing regex

  gabritto

  committed
  8e160cf

  Copy full SHA for 8e160cf

• Merge branch 'main' into gabritto/regiondiag

  gabritto

  committed
  30a0aad

  Copy full SHA for 30a0aad

Commits on May 23, 2024

• update unit tests logs with duration

  gabritto

  committed
  ece3c41

  Copy full SHA for ece3c41

• remove unused baseline

  gabritto

  committed
  0251194

  Copy full SHA for 0251194

• optimization: don't do region node selection if we will skip checking the file

  gabritto

  committed
  7076d14

  Copy full SHA for 7076d14

• don't record semantic diagnostic time if could have done region check

  gabritto

  committed
  48f87a8

  Copy full SHA for 48f87a8

• improve optimization

  gabritto

  committed
  81dc370

  Copy full SHA for 81dc370

Commits on May 24, 2024

• add line count and use it for deciding on region check

  gabritto

  committed
  5e6ce98

  Copy full SHA for 5e6ce98

Commits on May 30, 2024

• TEMPORARY FOR TESTING VSCODE

  gabritto

  committed
  3254be9

  Copy full SHA for 3254be9

• get rid of performance checking in heuristic for now

  gabritto

  committed
  ef6e4d5

  Copy full SHA for ef6e4d5

Commits on Jun 7, 2024

• CR: mark internal

  gabritto

  committed
  c07b226

  Copy full SHA for c07b226

• CR: refactor session.ts

  gabritto

  committed
  1f262cd

  Copy full SHA for 1f262cd

• always do semantic check in next immediate step

  gabritto

  committed
  34bcbb2

  Copy full SHA for 34bcbb2

• fix rebase problem

  gabritto

  committed
  52eadaa

  Copy full SHA for 52eadaa

Commits on Jun 10, 2024

• fix baselines

  gabritto

  committed
  12979b7

  Copy full SHA for 12979b7

• check files in the order of the request

  gabritto

  committed
  830c118

  Copy full SHA for 830c118

Commits on Jun 11, 2024

• refactor unit test

  gabritto

  committed
  d3a8f41

  Copy full SHA for d3a8f41

• add option for test session to always enable region checking

  gabritto

  committed
  1752f8f

  Copy full SHA for 1752f8f

• add test for skipped region diagnostics

  gabritto

  committed
  9320a45

  Copy full SHA for 9320a45

• format

  gabritto

  committed
  68831d1

  Copy full SHA for 68831d1

• Merge branch 'main' into gabritto/regiondiag

  gabritto

  committed
  2f2e02f

  Copy full SHA for 2f2e02f

• add test for file with ts-nocheck

  gabritto

  committed
  eb168b6

  Copy full SHA for eb168b6

Commits on Jun 12, 2024

• Merge branch 'main' into gabritto/regiondiag

  gabritto

  committed
  c571ae0

  Copy full SHA for c571ae0

• add comments and minor refactor

  gabritto

  committed
  7c512ac

  Copy full SHA for 7c512ac

Commits on Jun 13, 2024

• Merge branch 'main' into gabritto/regiondiag

  gabritto

  committed
  9f2727b

  Copy full SHA for 9f2727b

• refactor

  gabritto

  committed
  ec6772c

  Copy full SHA for ec6772c

• refactor updateErrorCheck to delay work again

  gabritto

  committed
  f1d87dc

  Copy full SHA for f1d87dc

• mark region threshold as internal

  gabritto

  committed
  5ed581a

  Copy full SHA for 5ed581a