Add missing test case for assertion functions with PropertySignature declarations
#59714
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR doesn't have any linked issues. Please open an issue that references this PR. From there we can discuss and prioritise. |
typescript-bot
added
the
For Uncommitted Bug
gabritto
approved these changes
Aug 22, 2024
Andarist
deleted the
tests/assertions-with-property-declarations-and-signatures
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was looking into
isDeclarationWithExplicitTypeAnnotationto assess if it's not missingMethodSignaturehandling. I couldn't come up with a test case that would prove it is. I think that case is always handled by an early check forSymbolFlags.MethodingetExplicitTypeOfSymbol(and that's the only caller ofisDeclarationWithExplicitTypeAnnotation).In the process, I found out that there was no test case for the
isPropertySignaturecheck inisDeclarationWithExplicitTypeAnnotation. So here it is (plus some extras) 😉