-
Notifications
You must be signed in to change notification settings - Fork 13k
Update DOM types for FileSystemDirectoryHandle changes #62538
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates DOM types for FileSystemDirectoryHandle changes by pulling in changes from the TypeScript-DOM-lib-generator to avoid conflicts with DefinitelyTyped. The main change involves updating type definitions for FileSystem API handles to be more specific about their types and properties.
Key Changes:
- Updated FileSystemHandle types to use union types (FileSystemDirectoryHandle | FileSystemFileHandle) instead of the base FileSystemHandle type
- Changed FileSystemHandleKind from enum to string literal union type ("directory" | "file")
Reviewed Changes
Copilot reviewed 4 out of 6 changed files in this pull request and generated no comments.
File | Description |
---|---|
tests/baselines/reference/modularizeLibrary_Worker.asynciterable.types | Updates baseline test expectations for Worker context FileSystem API types |
tests/baselines/reference/modularizeLibrary_Worker.asynciterable.symbols | Updates baseline test expectations for Worker context FileSystem API symbols |
tests/baselines/reference/modularizeLibrary_Dom.asynciterable.types | Updates baseline test expectations for DOM context FileSystem API types |
tests/baselines/reference/modularizeLibrary_Dom.asynciterable.symbols | Updates baseline test expectations for DOM context FileSystem API symbols |
@typescript-bot run dt |
Hey @jakebailey, the results of running the DT tests are ready. There were interesting changes: Errors that changed between main and the branch:Package: wicg-file-system-access
Branch error:
|
Hm, not quite clean. Will double check. |
Okay, still need one a oneliner: DefinitelyTyped/DefinitelyTyped#73820 |
@typescript-bot run dt |
Hey @jakebailey, the results of running the DT tests are ready. Everything looks the same! |
Pulls in microsoft/TypeScript-DOM-lib-generator#2186, see also DefinitelyTyped/DefinitelyTyped#73820.