Skip to content

Allow line break before import attributes with keyword #62593

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 14, 2025
Merged

Allow line break before import attributes with keyword #62593

merged 1 commit into from
Oct 14, 2025
+77 −1

Conversation

Andarist
Copy link
Contributor

fixes #62590

@github-project-automation github-project-automation bot moved this to Not started in PR Backlog Oct 14, 2025
@typescript-bot typescript-bot added the For Backlog Bug PRs that fix a backlog bug label Oct 14, 2025
RyanCavanaugh
RyanCavanaugh approved these changes Oct 14, 2025
View reviewed changes
Copy link
Member

@RyanCavanaugh RyanCavanaugh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Did assert actually have different ASI semantics? Doesn't really matter either way, just curious

@github-project-automation github-project-automation bot moved this from Not started to Needs merge in PR Backlog Oct 14, 2025
@RyanCavanaugh RyanCavanaugh merged commit d3be7e1 into microsoft:main Oct 14, 2025
33 checks passed
@github-project-automation github-project-automation bot moved this from Needs merge to Done in PR Backlog Oct 14, 2025
@Andarist
Copy link
Contributor Author

Did assert actually have different ASI semantics? Doesn't really matter either way, just curious

the OP in the issue mentioned it had but i didnt have energy to look for the source of this information

@Renegade334
Copy link
Contributor

Did assert actually have different ASI semantics? Doesn't really matter either way, just curious

tc39/ecma262#3057 (comment), for academic interest.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@RyanCavanaugh RyanCavanaugh RyanCavanaugh approved these changes

Assignees

No one assigned

Labels

For Backlog Bug PRs that fix a backlog bug

Projects

PR Backlog
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Allow line break before import attributes with keyword

4 participants

@Andarist @Renegade334 @RyanCavanaugh @typescript-bot