Fix module resolution falling back to classic #7065
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/harness/harness.ts
Outdated
| { name: "noErrorTruncation", type: "boolean" }, | ||
| { name: "suppressOutputPathCheck", type: "boolean" } | ||
| { name: "suppressOutputPathCheck", type: "boolean" }, | ||
| { name: "moduleResolution", type: "string"} |
There was a problem hiding this comment.
do we need this, I think that moduleResolution will already work since it is legal command line option
|
👍 to change modulo question in |
billti
added a commit
that referenced
this pull request
Feb 13, 2016
…edModuleKind Fix module resolution falling back to classic
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The actual module resolution algorithm was still falling back to
classicif the module kind wasn't specified explicitly in the settings. This fixes that (and impacts a lot of tests in the process).