Skip to content

use operator token when checking unary expressions in strict mode #736

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 24, 2014

Conversation

vladima
Copy link
Contributor

@vladima vladima commented Sep 24, 2014

fixes #734

@mhegazy
Copy link
Contributor

mhegazy commented Sep 24, 2014

👍

vladima added a commit that referenced this pull request Sep 24, 2014
use operator token when checking unary expressions in strict mode
@vladima vladima merged commit 9f23f74 into master Sep 24, 2014
@vladima vladima deleted the unary_operators_strict_mode branch September 24, 2014 17:56
eval++;
eval--;
arguments++;
arguments--;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add tests for the left hand side of an assignment operator?

@JsonFreeman
Copy link
Contributor

👍

@microsoft microsoft locked and limited conversation to collaborators Jun 18, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Version 1.1: parser.ts/parseUnaryExpression has incorrect logic in strict checks
3 participants