Skip to content

Show aliases in completion list #786

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 1, 2014
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/compiler/checker.ts
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,8 @@ module ts {
getFullyQualifiedName: getFullyQualifiedName,
getResolvedSignature: getResolvedSignature,
getEnumMemberValue: getEnumMemberValue,
isValidPropertyAccess: isValidPropertyAccess
isValidPropertyAccess: isValidPropertyAccess,
getAliasedSymbol: resolveImport
};

var undefinedSymbol = createSymbol(SymbolFlags.Property | SymbolFlags.Transient, "undefined");
Expand Down
1 change: 1 addition & 0 deletions src/compiler/types.ts
Original file line number Diff line number Diff line change
Expand Up @@ -657,6 +657,7 @@ module ts {
getEnumMemberValue(node: EnumMember): number;

isValidPropertyAccess(node: PropertyAccess, propertyName: string): boolean;
getAliasedSymbol(symbol: Symbol): Symbol;
}

export interface TextWriter {
Expand Down
11 changes: 10 additions & 1 deletion src/services/services.ts
Original file line number Diff line number Diff line change
Expand Up @@ -1025,6 +1025,8 @@ module ts {
static primitiveType = "primitive type";

static label = "label";

static alias = "alias"
}

export class ScriptElementKindModifier {
Expand Down Expand Up @@ -2145,6 +2147,12 @@ module ts {

if (mappedNode.kind === SyntaxKind.Identifier || mappedNode.kind === SyntaxKind.QualifiedName || mappedNode.kind === SyntaxKind.PropertyAccess) {
var symbol = typeInfoResolver.getSymbolInfo(mappedNode);

// This is an alias, follow what it aliases
if (symbol && symbol.flags & SymbolFlags.Import) {
symbol = typeInfoResolver.getAliasedSymbol(symbol);
}

if (symbol && symbol.flags & SymbolFlags.HasExports) {
// Extract module or enum members
forEachValue(symbol.exports, symbol => {
Expand Down Expand Up @@ -2195,7 +2203,7 @@ module ts {
else {
isMemberCompletion = false;
/// TODO filter meaning based on the current context
var symbolMeanings = SymbolFlags.Type | SymbolFlags.Value | SymbolFlags.Namespace;
var symbolMeanings = SymbolFlags.Type | SymbolFlags.Value | SymbolFlags.Namespace | SymbolFlags.Import;
var symbols = typeInfoResolver.getSymbolsInScope(mappedNode, symbolMeanings);

getCompletionEntriesFromSymbols(symbols, activeCompletionSession);
Expand Down Expand Up @@ -2293,6 +2301,7 @@ module ts {
if (flags & SymbolFlags.Constructor) return ScriptElementKind.constructorImplementationElement;
if (flags & SymbolFlags.TypeParameter) return ScriptElementKind.typeParameterElement;
if (flags & SymbolFlags.EnumMember) return ScriptElementKind.variableElement;
if (flags & SymbolFlags.Import) return ScriptElementKind.alias;

return ScriptElementKind.unknown;
}
Expand Down
15 changes: 15 additions & 0 deletions tests/cases/fourslash/completionListOnAliases.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
/// <reference path='fourslash.ts' />

////module M {
//// export var value;
////
//// import x = M;
//// /*1*/
//// x./*2*/
////}

goTo.marker("1");
verify.memberListContains("x", undefined, undefined, undefined ,/*kind: */ "alias");

goTo.marker("2");
verify.memberListContains("value");
74 changes: 74 additions & 0 deletions tests/cases/fourslash/completionListOnAliases2.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,74 @@
/// <reference path='fourslash.ts' />

////module M {
//// export interface I { }
//// export class C {
//// static property;
//// }
//// export enum E {
//// value = 0
//// }
//// export module N {
//// export var v;
//// }
//// export var V = 0;
//// export function F() { }
//// export import A = M;
////}
////
////import m = M;
////import c = M.C;
////import e = M.E;
////import n = M.N;
////import v = M.V;
////import f = M.F;
////import a = M.A;
////
////m./*1*/;
////c./*2*/;
////e./*3*/;
////n./*4*/;
////v./*5*/;
////f./*6*/;
////a./*7*/;


// Module m
goTo.marker("1");
verify.memberListContains("I");
verify.memberListContains("C");
verify.memberListContains("E");
verify.memberListContains("N");
verify.memberListContains("V");
verify.memberListContains("F");
verify.memberListContains("A");

// Class C
goTo.marker("2");
verify.memberListContains("property");

// Enum E
goTo.marker("3");
verify.memberListContains("value");

// Module N
goTo.marker("4");
verify.memberListContains("v");

// var V
goTo.marker("5");
verify.memberListContains("toFixed");

// function F
goTo.marker("6");
verify.memberListContains("call");

// alias a
goTo.marker("7");
verify.memberListContains("I");
verify.memberListContains("C");
verify.memberListContains("E");
verify.memberListContains("N");
verify.memberListContains("V");
verify.memberListContains("F");
verify.memberListContains("A");
13 changes: 13 additions & 0 deletions tests/cases/fourslash/completionListOnAliases3.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
/// <reference path='fourslash.ts' />

////declare module 'foobar' {
//// interface Q { x: number; }
////}
////declare module 'thing' {
//// import x = require('foobar');
//// var m: x./*1*/;
////}

// Q does not show up in member list of x
goTo.marker("1");
verify.memberListContains("Q");