Skip to content

Conversation

ghost
Copy link

@ghost ghost commented May 23, 2016

4 out of 6 parameters of verify.navigationBarContains were being ignored. Now we only ignore 2.
This highlights a few more issues that should be made:

1 Modules should have module children
For example, see the 'Foundation' module in navbar_contains-no-duplicates
and module B and module C in navibationBarItemsModules

2 Interfaces should be childItems
For example, see LocalInterfaceInConstructor and LocalInterfaceInMethod in navigationBarItemsInsideMethodsAndConstructors

3 enums should be childItems
For example, see LocalEnumInMethod in navigationBarItemsInsideMethodsAndConstructors
and Values in navigationBarItemsItems
and Values in navbar01

4 classes should be childItems
See class Point in navigationBarItemsItems
and Point in navbar01

5 Use (or get rid of) isAdditionalSpan and markerPosition
isAdditionalSpan: not sure what this is supposed to mean.
markerPosition: The value passed in is the index of the marker used, but not sure if it could be useful. Navigation bar items get sorted by name, not position.

@msftclas
Copy link

Hi @Andy-MS, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!


It looks like you're a Microsoft contributor (Andy Hanson). If you're full-time, we DON'T require a Contribution License Agreement. If you are a vendor, please DO sign the electronic Contribution License Agreement. It will take 2 minutes and there's no faxing! https://cla.microsoft.com.

TTYL, MSBOT;

@mhegazy
Copy link
Contributor

mhegazy commented May 23, 2016

thanks!

@mhegazy
Copy link
Contributor

mhegazy commented May 23, 2016

👍

@ghost ghost mentioned this pull request May 23, 2016
@ghost ghost merged commit 1f7d1d2 into master May 23, 2016
@ghost ghost deleted the navbar_tests branch May 23, 2016 18:32
@microsoft microsoft locked and limited conversation to collaborators Jun 19, 2018
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants