Make fourslash tests actually test parentName for navbar items #8762
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
4 out of 6 parameters of
verify.navigationBarContains
were being ignored. Now we only ignore 2.This highlights a few more issues that should be made:
1 Modules should have module children
For example, see the 'Foundation' module in navbar_contains-no-duplicates
and module B and module C in navibationBarItemsModules
2 Interfaces should be childItems
For example, see LocalInterfaceInConstructor and LocalInterfaceInMethod in navigationBarItemsInsideMethodsAndConstructors
3 enums should be childItems
For example, see LocalEnumInMethod in navigationBarItemsInsideMethodsAndConstructors
and Values in navigationBarItemsItems
and Values in navbar01
4 classes should be childItems
See class Point in navigationBarItemsItems
and Point in navbar01
5 Use (or get rid of) isAdditionalSpan and markerPosition
isAdditionalSpan: not sure what this is supposed to mean.
markerPosition: The value passed in is the index of the marker used, but not sure if it could be useful. Navigation bar items get sorted by name, not position.