This repository was archived by the owner on Oct 12, 2022. It is now read-only.
Image Board sample working #5
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes: - Replaced mongo.ts with an up-to-date mongo.d.ts - Changed connection routine in db.ts to connect properly - changed MongoDb version to a recent version compatible with the d.ts - Changed express version to use only 3.x versions (will need more work to suport 4.x) - Fixed some Jade syntax
|
Sorry, just got to this! Looks good. Everything looks to be working for me. While we figure out if PRs to the samples needs a CLA, would you mind filling one out just to be on the safe side? https://github.com/Microsoft/TypeScript/blob/master/CONTRIBUTING.md Once we have that, I'll go ahead and merge. |
|
Sorry, I can't sign that license agreement. I don't agree to waive my defence rights nor do I agree that Microsoft can recover legal costs from me. |
|
I'm looking into the CLA issue. Since we don't ship the samples, we may be able to do without it, but let me ask our legal. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses issue #1
Changes: