Reference RFC 1123 for header date format #296
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markweitzel
approved these changes
Oct 4, 2021
JeffreyRichter
approved these changes
Oct 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reverts a change I had made to use RFC 7231 rather than RFC 1123 as the reference for the date format to used for date values passed in headers.
I had switched the reference to RFC 7231 because I couldn't find the part of RFC 1123 that described date formats of the kind we use in headers. That's because RFC 1123 describes the date format in an obscure fashion -- as a modification to the date formation of RFC 822. So not that this is clear I'm reverting the change (and adding an explanation of the RFC 1123 date format).