Skip to content

Fix Azure Error Log #8266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 7, 2018
Merged

Fix Azure Error Log #8266

merged 1 commit into from
Sep 7, 2018

Conversation

vineetmimrot
Copy link
Member

Ignore throwing error on warning. Throw error only when error code is not 0.

doubleyewdee
doubleyewdee reviewed Sep 7, 2018
View reviewed changes
Copy link

@doubleyewdee doubleyewdee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest you not check for stderr and non-zero exit code both and just keep the non-zero check. Looking for stderr output here doesn't really help.

@vineetmimrot
Copy link
Member Author

@doubleyewdee I will make the changes in the next version. Thanks.

@vineetmimrot vineetmimrot merged commit fe7cda9 into master Sep 7, 2018
@vineetmimrot vineetmimrot deleted the users/vimimrot/fix-azure-cli branch December 11, 2018 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sachinma sachinma Awaiting requested review from sachinma

@thesattiraju thesattiraju Awaiting requested review from thesattiraju

1 more reviewer

@doubleyewdee doubleyewdee doubleyewdee left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vineetmimrot @doubleyewdee