Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show cosmosdb nosql resources in azure tree #25120

Conversation

languy
Copy link
Contributor

@languy languy commented Dec 12, 2023

Add support for Cosmos DB NoSql resources in the New Connection dialog Azure tree.

image

jhutchings1 and others added 30 commits June 17, 2020 12:49
* Add CodeQL Analysis workflow

* Fix path
@languy languy marked this pull request as ready for review December 12, 2023 12:28
@languy languy changed the title Languy show cosmosdb nosql resources in azure tree Show cosmosdb nosql resources in azure tree Dec 12, 2023
@coveralls
Copy link

coveralls commented Dec 12, 2023

Pull Request Test Coverage Report for Build 7207259726

Warning: This coverage report may be inaccurate.

We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
To ensure accuracy in future PRs, please see these guidelines.
A quick fix for this PR: rebase it; your next report should be accurate.

  • 23 of 32 (71.88%) changed or added relevant lines in 8 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.01%) to 41.608%

Changes Missing Coverage Covered Lines Changed/Added Lines %
extensions/azurecore/src/azureResource/providers/cosmosdb/nosql/cosmosDbNoSqlService.ts 4 6 66.67%
extensions/azurecore/src/azureResource/providers/universal/universalService.ts 0 3 0.0%
extensions/azurecore/src/azureResource/providers/cosmosdb/nosql/cosmosDbNoSqlTreeDataProvider.ts 10 14 71.43%
Files with Coverage Reduction New Missed Lines %
extensions/notebook/src/dialog/configurePython/configurePythonWizard.ts 1 46.46%
Totals Coverage Status
Change from base Build 7175736451: 0.01%
Covered Lines: 30838
Relevant Lines: 69418

💛 - Coveralls

@cheenamalhotra
Copy link
Member

Could you please add gifs/screenshots to the PR description to where you're able to connect to these resources from Azure tree and Browse > Azure tree views?

@languy
Copy link
Contributor Author

languy commented Dec 13, 2023

Could you please add gifs/screenshots to the PR description to where you're able to connect to these resources from Azure tree and Browse > Azure tree views?

Sure, I have added a screenshot (redacted to remove resources names).

Copy link
Member

@cheenamalhotra cheenamalhotra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small change.. otherwise LGTM.

@cheenamalhotra cheenamalhotra merged commit a8161ee into microsoft:main Dec 21, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants