Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SQL Migration] Add schema migration validation #25138

Merged
merged 2 commits into from
Dec 18, 2023

Conversation

siyao-Siyang
Copy link
Contributor

@siyao-Siyang siyao-Siyang commented Dec 18, 2023

  1. adding IR version validation. Before going to RP, if users enable schema migration and the IR node doesn't support schema migration, disable the schema migration option. The SQLDB migration validation failure rate will have significant reduction.
  2. Windows login is currently not supported in SHIR. Therefore, if users use WIndows auth to connect the source instance for schema mgiration, disable the schema migration option. The SQLDB migration failure due to "login failed for user" will have significant reduction.

In Step 4, adding infor banner
image

In Step 6, check the IR nodes version and windows login. If true, show the warning message on the top and disable the schema migration option.
image

image

@siyao-Siyang siyao-Siyang changed the title [SQL Migration] Add schema migration valication [SQL Migration] Add schema migration validation Dec 18, 2023
@coveralls
Copy link

Pull Request Test Coverage Report for Build 7251524594

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.001%) to 41.603%

Files with Coverage Reduction New Missed Lines %
extensions/notebook/src/dialog/configurePython/configurePythonWizard.ts 1 46.46%
Totals Coverage Status
Change from base Build 7233696407: -0.001%
Covered Lines: 30817
Relevant Lines: 69389

💛 - Coveralls

@siyao-Siyang siyao-Siyang merged commit e0e5987 into main Dec 18, 2023
12 checks passed
@siyao-Siyang siyao-Siyang deleted the users/siyao/win-irversion branch December 18, 2023 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants