Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Updated the correct resource group for DMS Service check. #25246

Merged
merged 1 commit into from
Jan 24, 2024

Conversation

krritik
Copy link
Contributor

@krritik krritik commented Jan 24, 2024

The current code was failing for scenarios when DMS service and target are in different resource groups.
Updated the correct resource group for DMS Service in IR Validation checks.

For more context regarding validation - #25138

@coveralls
Copy link

Pull Request Test Coverage Report for Build 7643187021

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 41.759%

Totals Coverage Status
Change from base Build 7633847852: 0.0%
Covered Lines: 30828
Relevant Lines: 69082

💛 - Coveralls

Copy link

@cpichuka cpichuka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add a test scenario in sign-off testing.

@krritik
Copy link
Contributor Author

krritik commented Jan 24, 2024

Can you please add a test scenario in sign-off testing.

Sure Chaithanya, I will do it.

@krritik krritik merged commit 37ae535 into main Jan 24, 2024
15 checks passed
@krritik krritik deleted the krritik/fixDMSResourceGroupCheck branch January 24, 2024 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants