Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add component governance detection to ci build v2. #5776

Merged
merged 7 commits into from
Jul 8, 2021

Conversation

BruceHaley
Copy link
Contributor

@BruceHaley BruceHaley commented Jul 8, 2021

Fixes #5354

Description

Add Component Governance Detection (CGD) to the BotBuilder-DotNet-CI-PR-yaml build.

Specific Changes

Add ci-component-detection-steps.yml.
Modify botbuilder-dotnet-ci.yml: Add CGD to the Release_Windows_Configuration_31 and the Release_Windows_Configuration_21 build jobs.
Update vulnerable dependencies to later versions in 2 projects.

@BruceHaley BruceHaley requested a review from mrivera-ms July 8, 2021 18:38
@BruceHaley BruceHaley changed the title Add component governance detection to ci build 2. Add component governance detection to ci build v2. Jul 8, 2021
@coveralls
Copy link
Collaborator

coveralls commented Jul 8, 2021

Pull Request Test Coverage Report for Build 257511

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 2 unchanged lines in 2 files lost coverage.
  • Overall coverage remained the same at 76.118%

Files with Coverage Reduction New Missed Lines %
/libraries/AdaptiveExpressions/BuiltinFunctions/GetNextViableTime.cs 1 90.91%
/libraries/AdaptiveExpressions/BuiltinFunctions/GetPreviousViableTime.cs 1 90.91%
Totals Coverage Status
Change from base Build 257469: 0.0%
Covered Lines: 23104
Relevant Lines: 30353

💛 - Coveralls

@mrivera-ms mrivera-ms marked this pull request as ready for review July 8, 2021 21:01
@mrivera-ms mrivera-ms requested a review from a team as a code owner July 8, 2021 21:01
Copy link
Contributor

@gabog gabog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adopt component detection in CI pipeline
4 participants