Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Azure Blob Storage should support Identity authentication #4446

Closed
XVincentX opened this issue Apr 6, 2023 · 7 comments · Fixed by #4486
Closed

Azure Blob Storage should support Identity authentication #4446

XVincentX opened this issue Apr 6, 2023 · 7 comments · Fixed by #4486
Assignees
Labels
feature-request A request for new functionality or an enhancement to an existing one. needs-triage The issue has just been created and it has not been reviewed by the team.

Comments

@XVincentX
Copy link
Member

Azure Blob Storage asks for a container name as well as a connection string, implying that the only way to use it is through a shared access key.

Azure Blob Storage should support Managed and System Identities to avoid having to put secrets here and there

@XVincentX XVincentX added feature-request A request for new functionality or an enhancement to an existing one. needs-triage The issue has just been created and it has not been reviewed by the team. labels Apr 6, 2023
@XVincentX
Copy link
Member Author

Current workaround for people that cannot wait for the fix:

const c = new BlobsStorage(
  "DefaultEndpointsProtocol=https;AccountName=baffino;AccountKey=fake;EndpointSuffix=core.windows.net",
  "fakeContainerName"
);

/* @ts-ignore */
c["_containerClient"] = new ContainerClient(
  env.BLOB_STORAGE_URL,
  new DefaultAzureCredential({ managedIdentityClientId: env.AZURE_CLIENT_ID })
);
return c;

tracyboehrer pushed a commit that referenced this issue Jun 9, 2023
…on (#4486)

* Add MSI authentication in blobsStorage

* Update unit tests for blobsStorage constructor
@XVincentX
Copy link
Member Author

Sweet. Has this been released?

@ceciliaavila
Copy link
Collaborator

Sweet. Has this been released?

Hi @XVincentX, these changes are included in the preview version 4.21.0-dev.20230612.5ee34c0.

@XVincentX
Copy link
Member Author

I downloaded that version but it sounds like the change was not included. I still can see the old constructor

@ceciliaavila
Copy link
Collaborator

I downloaded that version but it sounds like the change was not included. I still can see the old constructor

The new parameters (URL and credential) were added as optional in the old constructor.
image

@XVincentX
Copy link
Member Author

Yeah I can see the code matches. There is definitely wrong on my side. Thanks!

@BeigeBadger
Copy link

What stable version is this targeted to be released in v4.21.0? Is there an estimated release date for this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request A request for new functionality or an enhancement to an existing one. needs-triage The issue has just been created and it has not been reviewed by the team.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants