-
Notifications
You must be signed in to change notification settings - Fork 278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Locale Fixes #2105
Locale Fixes #2105
Conversation
@@ -351,9 +351,11 @@ describe(`BotFrameworkAdapter`, function () { | |||
|
|||
it('ConnectorClient should use httpClient from clientOptions', async () => { | |||
let sendRequestCalled = false; | |||
const outgoingMessageLocale = JSON.parse(JSON.stringify(outgoingMessage)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had to make a change to this test because instead of an activity with no locale coming back as:
{
...
text: 'blah'
...
}
...it would come back as:
{
...
text: 'blah',
locale: undefined
...
}
I'm a little worried that activity.locale = reference.locale
(in the above changes) could be a rare breaking change (should really only happen with something like assert.deepEqual()
or if (activity.locale !== undefined)
(?). This could be fixed by using something more like:
if (!reference.locale) { activity.locale = reference.locale; }
...but I figured the very low risk made the readability okay. Let me know if you feel otherwise.
Pull Request Test Coverage Report for Build 125203
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixes #2093
Fixes #2032 (most of this was done in this PR, except for one tiny change to SkillHandler.
Description
Testing
Added checks for
locale
in existing tests.