Clean up graphqlpeg::parse_error exception messages #33
+654
−90
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PEGTL has a default control template class (
normal
) which raisesparse_error
exceptions using the type name of the required rule that was not matched. Some of the types in my GraphQL grammar were ambiguous and hard to map to the grammar rule that expected them.I refactored the grammar to use a custom control template and I encapsulated all of the
must
orif_must
rules which are the only valid match in those locations with*_content
rules that can be unambiguously specialized in the control template class.