Skip to content

Conversation

mbodmer
Copy link
Contributor

@mbodmer mbodmer commented Feb 15, 2019

No description provided.

Signed-off-by: Marc Bodmer <marc.bodmer@securiton.ch>
Signed-off-by: Marc Bodmer <marc.bodmer@securiton.ch>
@msftclas
Copy link

msftclas commented Feb 15, 2019

CLA assistant check
All CLA requirements met.

@wravery wravery self-assigned this Feb 27, 2019
CMakeLists.txt Outdated
EXPORT cppgraphqlgen-targets
RUNTIME DESTINATION bin
ARCHIVE DESTINATION lib
LIBRARY DESTINATION lib)

if(USE_RAPIDJSON)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just turning off USE_RAPIDJSON fails to build the tests. I want to see if I can make that conditional on providing an implementation of graphqljson instead, either with USE_RAPIDJSON or by including another implementation.

@wravery wravery merged commit a50660c into microsoft:master Feb 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants