Skip to content

Add tests reported in Github issues. #1001

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 19, 2018
Merged

Add tests reported in Github issues. #1001

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b4112a0
Add tests reported in Github issues.
BillyONeal Dec 18, 2018
a43b23a
Fix lying ampersand comment.
BillyONeal Dec 19, 2018
40f95c0
Fix missing string escape.
BillyONeal Dec 19, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Release/src/uri/uri.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,7 @@ namespace
/// - The percent character ('%'), and thus any percent-endcoded octet
/// - The sub-delimiters
/// - ':' (colon)
/// - '@' (ampersand)
/// - '@' (at sign)
/// </summary>
inline bool is_path_character(int c)
{
Expand Down
10 changes: 7 additions & 3 deletions Release/tests/functional/json/construction_tests.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -211,7 +211,7 @@ TEST(object_construction)
f.push_back(std::make_pair(U("abc"), json::value(true)));
f.push_back(std::make_pair(U("xyz"), json::value(44)));
json::value obj = json::value::object(f);

VERIFY_ARE_EQUAL(f.size(), obj.size());

obj[U("abc")] = json::value::string(U("str"));
Expand Down Expand Up @@ -320,7 +320,7 @@ TEST(array_construction)
TEST(array_test)
{
json::value arr = json::value::array();
const json::value& carr = arr;
const json::value& carr = arr;
arr[0] = json::value(3.14);
arr[1] = json::value(true);
arr[2] = json::value("Yes");
Expand Down Expand Up @@ -486,7 +486,11 @@ TEST(object_test)
VERIFY_ARE_EQUAL(cobject.size(), count);
}

TEST(github_asan_989)
{
::web::json::value::parse( _XPLATSTR(R"([ { "k1" : "v" }, { "k2" : "v" }, { "k3" : "v" }, { "k4" : "v" } ])") );
}

} // SUITE(construction_tests)

}}}

5 changes: 5 additions & 0 deletions Release/tests/functional/uri/uri_builder_tests.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -572,6 +572,11 @@ TEST(append_query_locale, "Ignore:Android", "Locale unsupported on Android")
VERIFY_ARE_EQUAL(expected, builder.query());
}

TEST(github_crash_994)
{
web::uri uri(U("http://127.0.0.1:34568/"));
}

} // SUITE(uri_builder_tests)

}}}