Skip to content

json: {"meow"} is not a valid object #1130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 7, 2019
Merged

json: {"meow"} is not a valid object #1130

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
96fc0d1
json: {"meow"} is not a valid object
garethsb May 2, 2019
912c06d
Add to contributors - eighteenth PR seemed like the time! :-)
garethsb May 2, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CONTRIBUTORS.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,3 +54,6 @@ leetal

Benjamin Lee (mobileben)
René Meusel (reneme)

Sony Corporation
Gareth Sylvester-Bradley (garethsb-sony)
2 changes: 1 addition & 1 deletion Release/src/json/json_parsing.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -965,7 +965,7 @@ std::unique_ptr<web::json::details::_Value> JSON_Parser<CharType>::_ParseObject(
if (tkn.m_error) goto error;

// State 2: Looking for a colon.
if (tkn.kind != JSON_Parser<CharType>::Token::TKN_Colon) goto done;
if (tkn.kind != JSON_Parser<CharType>::Token::TKN_Colon) goto error;

GetNextToken(tkn);
if (tkn.m_error) goto error;
Expand Down
6 changes: 6 additions & 0 deletions Release/tests/functional/json/parsing_tests.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -469,6 +469,12 @@ SUITE(parsing_tests)
VERIFY_ARE_EQUAL(0u, arr.size());
}

TEST(bug_object_field_key_no_value)
{
VERIFY_PARSING_THROW(json::value::parse(U("{\"meow\"}")));
VERIFY_PARSING_THROW(json::value::parse(U("{\"meow\": 42, \"purr\": 57, \"hiss\"}")));
}

TEST(bug_416116)
{
json::value data2 = json::value::parse(U("\"δοκιμή\""));
Expand Down