Handled uncaught exception when request contains bad encoded URI #415
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@JoshuaBehrens, It will cover your contributions to all Microsoft-managed open source projects. |
|
@JoshuaBehrens, thanks for signing the contribution license agreement. We will now validate the agreement and then the pull request. |
ras0219-msft
added a commit
that referenced
this pull request
Apr 28, 2017
ras0219-msft
added a commit
that referenced
this pull request
Apr 28, 2017
Handled uncaught exception when request contains bad encoded URI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you launch a simple server using this SDK and make a GET on any URI, the server crashes due to an uncaught exception. I can't catch it by myself as it is thrown when the incoming request gets analyzed to choose the right handler.
I chose the BadRequest error code as it best fits the situation. I could not inspect the windows server as I do not have a windows system at hand.