Skip to content

Conversation

ashwinravianandan
Copy link
Contributor

No description provided.

@msftclas
Copy link

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. We will now review your pull request.
Thanks,
Microsoft Pull Request Bot

@ras0219-msft ras0219-msft merged commit 7dca8e4 into microsoft:master Jul 12, 2017
@garethsb
Copy link
Contributor

garethsb commented Oct 31, 2017

Hi @ras0219-msft @ashwinravianandan

What is the rationale for adding support for "+" but not "*"?
Is the difference between a "strong wildcard" and a "weak wildcard" relevant here?
Cf. base_uri::is_host_wildcard() reports true for both... (https://github.com/Microsoft/cpprestsdk/blob/master/Release/include/cpprest/base_uri.h#L350)

(Related question... Should "0.0.0.0" be mapped to a wildcard on Windows, or the wildcard approach be documented as the cross-platform solution? That has come up several times before, e.g. #380.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants