Improve http_proxy handling in BingRequest sample #494
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using empty proxy URI results in failing to open the connection when using WinHTTP, so the current code is broken out of the box.
|
@vadz, |
The length returned by _wdupenv_s() includes the terminating NUL character, which isn't really part of the string. URI parsing seems to discard it anyhow currently (intentionally or not?), but including it breaks comparisons with any literal strings, for example, such as are done in the upcoming commit.
Allow easily testing proxy auto-discovery using this sample too.
vadz
changed the title
|
This seems good to me, thanks for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR consists of 2 somewhat independent parts (I decided it would be more convenient to have them in the same PR, but please let me know if you want me to split it in 2): first, and most importantly, the first commit fixes the sample behaviour by default as currently it just fails to open connection if
http_proxyis not defined, so it's broken out of the box. This is especially annoying because there is no exception handling in the sample (which is IMO far from ideal, but I didn't change this because this is, perhaps, intentional to keep things simple?), so it simply crashes without any explanation as to why does it happen.Second, the 2nd and 3rd commits allow to use
http_proxy=autowith this sample as it's convenient for testing.