Fix building with LibreSSL #562
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LibreSSL is backwards compatible with OpenSSL 1.0, however it reports it's version number as 2.0, which then causes build failures when using OPENSSL_VERSION_NUMBER. Adding a check for LIBRESSL_VERSION_NUMBER when checking if the openssl version number is < 0x10100000L fixes the issue.
|
LGTM, thanks for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LibreSSL is backwards compatible with OpenSSL 1.0, however it reports
it's version number as 2.0, which then causes build failures when using
OPENSSL_VERSION_NUMBER.
Adding a check for LIBRESSL_VERSION_NUMBER when checking if the OpenSSL
version number is < 0x10100000L fixes the issue.