chore: check if checkbox is checked #63
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mxschmitt
reviewed
Oct 31, 2022
assets/demo-todo-app.spec.js
Outdated
| @@ -168,13 +168,20 @@ test.describe('Item', () => { | |||
|
|
|||
| const firstTodo = page.getByTestId('todo-item').nth(0); | |||
| const secondTodo = page.getByTestId('todo-item').nth(1); | |||
| await firstTodo.getByRole('checkbox').check(); | |||
| const firstTodoCheck = firstTodo.getByRole('checkbox'); | |||
There was a problem hiding this comment.
Suggested change
| const firstTodoCheck = firstTodo.getByRole('checkbox'); | |
| const firstTodoCheckbox = firstTodo.getByRole('checkbox'); |
don't call it Check, call it Checkbox
mxschmitt
reviewed
Oct 31, 2022
assets/demo-todo-app.spec.js
Outdated
| const secondTodoCheck = secondTodo.getByRole('checkbox'); | ||
|
|
||
| await firstTodoCheck.check(); | ||
| await expect(firstTodoCheck).toBeChecked(); |
There was a problem hiding this comment.
I feel like this assertion does not make a lot of sense, since a checkbox is always checked if you check it. Isn't asserting for the completed class already enough?
There was a problem hiding this comment.
ok perhaps. no idea to be honest.
dgozman
approved these changes
Nov 1, 2022
assets/demo-todo-app.spec.js
Outdated
| @@ -168,12 +168,15 @@ test.describe('Item', () => { | |||
|
|
|||
| const firstTodo = page.getByTestId('todo-item').nth(0); | |||
| const secondTodo = page.getByTestId('todo-item').nth(1); | |||
| await firstTodo.getByRole('checkbox').check(); | |||
| const firstTodoCheckbox = firstTodo.getByRole('checkbox'); | |||
| const secondTodoCheckbox = secondTodo.getByRole('checkbox'); | |||
assets/demo-todo-app.spec.js
Outdated
| @@ -317,8 +320,10 @@ test.describe('Persistence', () => { | |||
| } | |||
|
|
|||
| const todoItems = page.getByTestId('todo-item'); | |||
| await todoItems.nth(0).getByRole('checkbox').check(); | |||
| const firstTodoCheck = todoItems.nth(0).getByRole('checkbox') | |||
There was a problem hiding this comment.
Suggested change
| const firstTodoCheck = todoItems.nth(0).getByRole('checkbox') | |
| const firstTodoCheck = todoItems.nth(0).getByRole('checkbox'); |
assets/demo-todo-app.spec.ts
Outdated
| @@ -167,12 +167,15 @@ test.describe('Item', () => { | |||
|
|
|||
| const firstTodo = page.getByTestId('todo-item').nth(0); | |||
| const secondTodo = page.getByTestId('todo-item').nth(1); | |||
| await firstTodo.getByRole('checkbox').check(); | |||
| const firstTodoCheckbox = firstTodo.getByRole('checkbox'); | |||
| const secondTodoCheckbox = secondTodo.getByRole('checkbox'); | |||
assets/demo-todo-app.spec.ts
Outdated
| @@ -316,8 +319,10 @@ test.describe('Persistence', () => { | |||
| } | |||
|
|
|||
| const todoItems = page.getByTestId('todo-item'); | |||
| await todoItems.nth(0).getByRole('checkbox').check(); | |||
| const firstTodoCheck = todoItems.nth(0).getByRole('checkbox') | |||
There was a problem hiding this comment.
Suggested change
| const firstTodoCheck = todoItems.nth(0).getByRole('checkbox') | |
| const firstTodoCheck = todoItems.nth(0).getByRole('checkbox'); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.