GH-1230 Use find_namespace_packages() #1244
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@microsoft-github-policy-service agree |
darrenmeehan
commented
Mar 17, 2023
| packages=setuptools.find_namespace_packages( | ||
| include=[ | ||
| "debugpy", | ||
| "debugpy.*", |
There was a problem hiding this comment.
I need to confirm whether both entries are required here.
|
Given the implications of the change, I think this should be a PR on https://github.com/fabioz/PyDev.Debugger for maximum visibility. As I understand it, switching the pydevd packages from classic to init-less is going to affect all the pydevd extensions out there that use the old API. But, conversely, the extensions cannot update until pydevd itself does. So the hard part here isn't the fix itself, but rather coordinating the change across the ecosystem. That said, depending on the expected timeline, we might want to apply a local fix temporarily. |
|
An equivalent fix has been merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm putting this up for review ahead of testing to allow some conversation on what the desired approach for addressing #1230 should be.
Fixes #1230