-
Notifications
You must be signed in to change notification settings - Fork 334
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Dev][Build] .NET 8 Upgrade #1968
Merged
EricJohnson327
merged 34 commits into
microsoft:main
from
snickler:user/snickler/net8-upgrade
Jan 18, 2024
Merged
[Dev][Build] .NET 8 Upgrade #1968
EricJohnson327
merged 34 commits into
microsoft:main
from
snickler:user/snickler/net8-upgrade
Jan 18, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
/azp run |
No pipelines are associated with this pull request. |
@crutkas - It says that it's waiting for an approval from a maintainer to kick off. https://github.com/microsoft/devhome/actions/runs/7021700211 |
/azp run |
No pipelines are associated with this pull request. |
@snickler is this ready for a review? |
Not yet. This next commit I'm about to do in the next half hour will make it ready 😎 |
dhoehna
reviewed
Dec 1, 2023
dhoehna
reviewed
Dec 1, 2023
dhoehna
reviewed
Dec 1, 2023
EricJohnson327
approved these changes
Jan 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the pull request
Initial modifications to allow for .NET 8 targeting.
References and relevant issues
#1957
Detailed description of the pull request / Additional comments
Outstanding issue as of now involves AdaptiveCards, but currently looking into it.
Validation steps performed
PR checklist