Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dev][Build] .NET 8 Upgrade #1968

Merged
merged 34 commits into from Jan 18, 2024

Conversation

snickler
Copy link
Contributor

Summary of the pull request

Initial modifications to allow for .NET 8 targeting.

References and relevant issues

#1957

Detailed description of the pull request / Additional comments

  • Libraries updated to compatible versions
  • Code changes to satisfy Code Analysis warnings
  • RuntimeIdentifiers updated to be win-(plat) / RuntimeIdentifiers added to Unit Tests
  • Build updated to use .NET 8 SDK

Outstanding issue as of now involves AdaptiveCards, but currently looking into it.

Validation steps performed

PR checklist

@crutkas
Copy link
Member

crutkas commented Nov 29, 2023

/azp run

Copy link

No pipelines are associated with this pull request.

@snickler
Copy link
Contributor Author

@crutkas - It says that it's waiting for an approval from a maintainer to kick off. https://github.com/microsoft/devhome/actions/runs/7021700211

@crutkas
Copy link
Member

crutkas commented Nov 30, 2023

/azp run

Copy link

No pipelines are associated with this pull request.

@crutkas
Copy link
Member

crutkas commented Nov 30, 2023

@snickler is this ready for a review?

@snickler
Copy link
Contributor Author

@snickler is this ready for a review?

Not yet. This next commit I'm about to do in the next half hour will make it ready 😎

@snickler snickler marked this pull request as ready for review December 1, 2023 15:45
@snickler snickler changed the title [WIP][Dev][Build] .NET 8 Upgrade [Dev][Build] .NET 8 Upgrade Dec 1, 2023
@EricJohnson327 EricJohnson327 merged commit 2f2ba18 into microsoft:main Jan 18, 2024
4 checks passed
dhoehna pushed a commit that referenced this pull request Feb 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade to .NET 8
4 participants