-
Notifications
You must be signed in to change notification settings - Fork 323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Git status refinements and support vfs/gvfs repos #3556
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DefaultRyan
changed the title
Git status refinements
Git status refinements and support vfs/gvfs repos
Aug 6, 2024
krschau
approved these changes
Aug 7, 2024
dhoehna
reviewed
Aug 7, 2024
extensions/GitExtension/FileExplorerGitIntegration/Models/GitRepositoryStatus.cs
Show resolved
Hide resolved
dhoehna
reviewed
Aug 7, 2024
extensions/GitExtension/FileExplorerGitIntegration/Models/StatusCache.cs
Show resolved
Hide resolved
dhoehna
reviewed
Aug 7, 2024
extensions/GitExtension/FileExplorerGitIntegration/Models/StatusCache.cs
Outdated
Show resolved
Hide resolved
dhoehna
reviewed
Aug 7, 2024
extensions/GitExtension/FileExplorerGitIntegration/Models/StatusCache.cs
Outdated
Show resolved
Hide resolved
dhoehna
reviewed
Aug 7, 2024
extensions/GitExtension/FileExplorerGitIntegration/Models/ThrottledTask.cs
Show resolved
Hide resolved
ssparach
approved these changes
Aug 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the pull request
References and relevant issues
Detailed description of the pull request / Additional comments
There's some code movement here to move
GitRepositoryStatus
andGitStatusEntry
from RepositoryWrapper.cs to their own files.Introduced StatusCache which caches the most-recently obtained status and queues status updates in response to filesystem changes in the repo.
These updates are throttled so that if multiple file events arrive rapidly, we don't fetch another status update until the prior one has completed and the waiting period expires (currently 3 seconds).
Validation steps performed
Built a private DevHome build.
Verified that file status still appears as expected. Verified that file and repo status both eventually report the correct status after making multiple rapid file changes.
Attached a debugger with printing breakpoints to validate that even when making multiple rapid file changes, the status is only updated after a 3 second delay.
PR checklist