Compatible with 3.7 onwards #10
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Deepanshu Agarwal <deepanshu.agarwal1984@gmail.com>
cgillum
reviewed
May 3, 2023
setup.py
Outdated
| # Copyright (c) Microsoft Corporation. | ||
| # Licensed under the MIT License. | ||
|
|
||
| import setuptools |
There was a problem hiding this comment.
Why do we need setup.py to support 3.7?
There was a problem hiding this comment.
I have been publishing using setup.py on Pypi, but as discussed I will use pyproject.toml, and will create a separate PR for it. So, removed it.
Signed-off-by: Deepanshu Agarwal <deepanshu.agarwal1984@gmail.com>
DeepanshuA
commented
May 3, 2023
| @@ -9,7 +9,7 @@ build-backend = "setuptools.build_meta" | |||
|
|
|||
| [project] | |||
| name = "durabletask" | |||
| version = "0.1.0" | |||
| version = "0.1.0-alpha.3" | |||
There was a problem hiding this comment.
Reviewers: Right now, publishing only alpha versions.
DeepanshuA
changed the title
Signed-off-by: Deepanshu Agarwal <deepanshu.agarwal1984@gmail.com>
Signed-off-by: Deepanshu Agarwal <deepanshu.agarwal1984@gmail.com>
Signed-off-by: Deepanshu Agarwal <deepanshu.agarwal1984@gmail.com>
Signed-off-by: Deepanshu Agarwal <deepanshu.agarwal1984@gmail.com>
Signed-off-by: Deepanshu Agarwal <deepanshu.agarwal1984@gmail.com>
cgillum
reviewed
May 3, 2023
.github/workflows/pr-validation.yml
Outdated
| pip install -r requirements.txt | ||
| - name: Lint with flake8 | ||
| run: | | ||
| flake8 . --count --show-source --statistics --exit-zero | ||
| tox -e flake8 |
There was a problem hiding this comment.
Why do we need to replace the flake8 command with a tox command?
There was a problem hiding this comment.
Ohh, I had updated the PR but forgot to comment here.
As discussed, have updated with an if condition to skip linting check for 3.7 ver.
And, build is green now.
Please check.
Signed-off-by: Deepanshu Agarwal <deepanshu.agarwal1984@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to make durabletask compatible with 3.7 onwards.