Add accessibility rules for InfoLabel, MenuButton, SplitButton, and Card components #163
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ard components. Add required test cases. Update coverage.md.
OjhaAditi25
reviewed
Sep 19, 2025
…entui-jsx-a11y into users/sidhshar/accessibility-rules-for-infolabel-menubutton-splitbutton-and-card-components
aubreyquinn
deleted the
users/sidhshar/accessibility-rules-for-infolabel-menubutton-splitbutton-and-card-components
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎯 Overview
This PR implements accessibility rules for 4 previously uncovered FluentUI components as part of expanding ESLint plugin coverage for better React accessibility compliance.
🚀 Changes Made
New Accessibility Rules Added:
infolabel-needs-labelling) - Ensures InfoLabel components have proper accessible namesmenu-button-needs-labelling) - Validates MenuButton accessibility labelingsplit-button-needs-labelling) - Ensures SplitButton components are properly labeledcard-needs-accessible-name) - Validates Card components have accessible names when interactiveTechnical Implementation:
makeLabeledControlRulefactory patternlabelUtils.ts([A-Za-l0-9_$]→[A-Za-z0-9_$])COVERAGE.mdto mark all 4 components as implemented[x]This PR also addresses one bug that was found during testing : Resolved identifier regex validation in labelUtils.ts